From: "David S. Miller" <davem@davemloft.net>
To: vda@ilport.com.ua
Cc: linux-kernel@vger.kernel.org, linux-net@vger.kernel.org,
netdev@vger.kernel.org
Subject: Re: [PATCH 3/3] deinline a few large functions in vlan code - v3
Date: Tue, 11 Apr 2006 00:58:58 -0700 (PDT) [thread overview]
Message-ID: <20060411.005858.49205474.davem@davemloft.net> (raw)
In-Reply-To: <200604111047.36941.vda@ilport.com.ua>
From: Denis Vlasenko <vda@ilport.com.ua>
Date: Tue, 11 Apr 2006 10:47:36 +0300
> On Tuesday 11 April 2006 10:44, Denis Vlasenko wrote:
> On Tuesday 11 April 2006 10:43, Denis Vlasenko wrote:
> > These patches exclude VLAN code from netdevice drivers
> > and from bonding module, and even remove vlan-related
> > members of struct netdevice if VLAN is not configured.
> >
> > Compile tested on allyesconfig kernel with CONFIG_8021Q=y,m,n.
>
> This one add #ifdefs around vlan_rx_* members of struct netdevice,
> and moves large inlines out-of-line.
This is not very nice, there is no way I'm applying these patches.
I think the current situation is far better than the large pile of
ifdefs these patches are adding to the tree.
Let's just leave things the way they are ok?
next prev parent reply other threads:[~2006-04-11 7:58 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-04-11 7:43 [PATCH 1/3] deinline a few large functions in vlan code - v3 Denis Vlasenko
2006-04-11 7:44 ` [PATCH 2/3] " Denis Vlasenko
2006-04-11 7:47 ` [PATCH 3/3] " Denis Vlasenko
2006-04-11 7:58 ` David S. Miller [this message]
2006-04-11 8:11 ` Denis Vlasenko
2006-04-11 8:36 ` David S. Miller
2006-04-11 12:24 ` Denis Vlasenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060411.005858.49205474.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-net@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=vda@ilport.com.ua \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).