From: Stephen Hemminger <shemminger@osdl.org>
To: Herbert Xu <herbert@gondor.apana.org.au>
Cc: davem@davemloft.net, chas@cmf.nrl.navy.mil,
linux-atm-general@lists.sourceforge.net, netdev@vger.kernel.org,
stable@kernel.org
Subject: Re: [PATCH] atm: clip causes unregister hang
Date: Wed, 12 Apr 2006 13:15:27 -0700 [thread overview]
Message-ID: <20060412131527.71f42d58@localhost.localdomain> (raw)
In-Reply-To: <20060412200015.GA19878@gondor.apana.org.au>
On Thu, 13 Apr 2006 06:00:15 +1000
Herbert Xu <herbert@gondor.apana.org.au> wrote:
> Hi Stephen:
>
> On Wed, Apr 12, 2006 at 12:45:33PM -0700, Stephen Hemminger wrote:
> >
> > /* ignore non-CLIP devices */
> > - if (((struct net_device *) dev)->type != ARPHRD_ATM ||
> > - ((struct net_device *) dev)->hard_start_xmit != clip_start_xmit)
> > + if (dev->type != ARPHRD_ATM || dev->hard_start_xmit != clip_start_xmit)
> > return NOTIFY_DONE;
>
> I think we need to check whether atm_init_atmarp has been done before
> passing this point. We also need to make sure that it doesn't get pulled
> out from under us while we're doing this.
>
> Cheers,
If atm_init_atmarp has not been done, then to_atamarpd is a nop because
atmarpd == NULL.
next prev parent reply other threads:[~2006-04-12 20:15 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-04-12 17:55 [PATCH] atm: clip causes unregister hang Stephen Hemminger
2006-04-12 18:08 ` Herbert Xu
2006-04-12 19:45 ` Stephen Hemminger
2006-04-12 20:00 ` Herbert Xu
2006-04-12 20:15 ` Stephen Hemminger [this message]
2006-04-12 20:25 ` Herbert Xu
2006-04-12 21:52 ` Stephen Hemminger
2006-04-12 22:42 ` [PATCH] atm: clip timer race Stephen Hemminger
2006-04-13 12:45 ` Herbert Xu
2006-04-13 17:26 ` Stephen Hemminger
2006-04-13 17:31 ` Herbert Xu
2006-04-13 21:08 ` Roland Dreier
2006-04-13 22:11 ` Herbert Xu
2006-04-14 22:56 ` David S. Miller
2006-04-13 12:28 ` [PATCH] atm: clip causes unregister hang Herbert Xu
2006-04-14 22:07 ` David S. Miller
2006-04-13 22:22 ` [PATCH 1/4] clip: run through Lindent Stephen Hemminger
2006-04-13 22:24 ` [PATCH 4/4] clip: add module info Stephen Hemminger
2006-04-13 22:45 ` [stable] [PATCH 1/4] clip: run through Lindent Greg KH
2006-04-14 9:01 ` David S. Miller
2006-04-14 22:58 ` David S. Miller
2006-04-14 22:59 ` David S. Miller
[not found] ` <20060413151945.0f181d04@localhost.localdomain>
2006-04-13 22:23 ` [PATCH 3/4] clip: notifier related cleanups Stephen Hemminger
2006-04-13 22:23 ` [PATCH 2/4] clip: get rid of PROC_FS ifdef Stephen Hemminger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060412131527.71f42d58@localhost.localdomain \
--to=shemminger@osdl.org \
--cc=chas@cmf.nrl.navy.mil \
--cc=davem@davemloft.net \
--cc=herbert@gondor.apana.org.au \
--cc=linux-atm-general@lists.sourceforge.net \
--cc=netdev@vger.kernel.org \
--cc=stable@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).