From: "John W. Linville" <linville@tuxdriver.com>
To: Carlos Martin <carlos@cmartin.tk>
Cc: netdev@vger.kernel.org, Denis Vlasenko <vda@ilport.com.ua>,
acx100-devel@lists.sourceforge.net
Subject: Re: [PATCH] acxsm: Reduce the number of ACX_PACKED instructions
Date: Wed, 12 Apr 2006 16:58:01 -0400 [thread overview]
Message-ID: <20060412205756.GD12788@tuxdriver.com> (raw)
In-Reply-To: <11433168763687-git-send-email-carlos@cmartin.tk>
On Sat, Mar 25, 2006 at 09:01:16PM +0100, Carlos Martin wrote:
> Up to now, we were using ACX_PACKED after every field. I've finally
> found out how to use only one at the end of each struct whilst
> maintaining the typedef where it is now.
>
> This should also apply to acx with a bit of fuzz, but I consider it to
> be in maintenance mode, so this doesn't qualify for it.
>
> Signed-off-by: Carlos Martin <carlos@cmartin.tk>
>
> ---
>
> acx_struct.h | 874 +++++++++++++++++++++++++++++-----------------------------
> common.c | 26 +-
> ioctl.c | 10 -
> usb.c | 8 -
> 4 files changed, 457 insertions(+), 461 deletions(-)
>
> 5fb2fdfd8c028a40921bbf9ef7ec4c53c03fcab4
> diff --git a/acx_struct.h b/acx_struct.h
Denis, have you got this patch? Or do I need to apply it?
Carlos, please make your diffs from the root of the kernel tree.
Thanks,
John
--
John W. Linville
linville@tuxdriver.com
next prev parent reply other threads:[~2006-04-12 20:58 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-03-25 20:01 [PATCH] acxsm: Reduce the number of ACX_PACKED instructions Carlos Martin
2006-04-12 20:58 ` John W. Linville [this message]
2006-04-13 12:33 ` Denis Vlasenko
2006-04-13 13:08 ` John W. Linville
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060412205756.GD12788@tuxdriver.com \
--to=linville@tuxdriver.com \
--cc=acx100-devel@lists.sourceforge.net \
--cc=carlos@cmartin.tk \
--cc=netdev@vger.kernel.org \
--cc=vda@ilport.com.ua \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).