netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Stephen Hemminger <shemminger@osdl.org>
To: "David S. Miller" <davem@davemloft.net>
Cc: chas@cmf.nrl.navy.mil, linux-atm-general@lists.sourceforge.net,
	netdev@vger.kernel.org, stable@kernel.org
Subject: [PATCH 2/4] clip: get rid of PROC_FS ifdef
Date: Thu, 13 Apr 2006 15:23:15 -0700	[thread overview]
Message-ID: <20060413152315.05051c08@localhost.localdomain> (raw)
In-Reply-To: <20060413151945.0f181d04@localhost.localdomain>

Don't need the ifdef here since create_proc_entry() is stubbed to always
return NULL.

Signed-off-by: Stephen Hemminger <shemminger@osdl.org>


--- clip.orig/net/atm/clip.c	2006-04-13 15:18:21.000000000 -0700
+++ clip/net/atm/clip.c	2006-04-13 15:20:26.000000000 -0700
@@ -976,6 +976,7 @@
 
 static int __init atm_clip_init(void)
 {
+	struct proc_dir_entry *p;
 	neigh_table_init(&clip_tbl);
 
 	clip_tbl_hook = &clip_tbl;
@@ -985,15 +986,9 @@
 
 	setup_timer(&idle_timer, idle_timer_check, 0);
 
-#ifdef CONFIG_PROC_FS
-	{
-		struct proc_dir_entry *p;
-
-		p = create_proc_entry("arp", S_IRUGO, atm_proc_root);
-		if (p)
-			p->proc_fops = &arp_seq_fops;
-	}
-#endif
+	p = create_proc_entry("arp", S_IRUGO, atm_proc_root);
+	if (p)
+		p->proc_fops = &arp_seq_fops;
 
 	return 0;
 }

      parent reply	other threads:[~2006-04-13 22:25 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-04-12 17:55 [PATCH] atm: clip causes unregister hang Stephen Hemminger
2006-04-12 18:08 ` Herbert Xu
2006-04-12 19:45   ` Stephen Hemminger
2006-04-12 20:00     ` Herbert Xu
2006-04-12 20:15       ` Stephen Hemminger
2006-04-12 20:25         ` Herbert Xu
2006-04-12 21:52           ` Stephen Hemminger
2006-04-12 22:42             ` [PATCH] atm: clip timer race Stephen Hemminger
2006-04-13 12:45               ` Herbert Xu
2006-04-13 17:26                 ` Stephen Hemminger
2006-04-13 17:31                   ` Herbert Xu
2006-04-13 21:08                 ` Roland Dreier
2006-04-13 22:11                   ` Herbert Xu
2006-04-14 22:56               ` David S. Miller
2006-04-13 12:28             ` [PATCH] atm: clip causes unregister hang Herbert Xu
2006-04-14 22:07             ` David S. Miller
2006-04-13 22:22 ` [PATCH 1/4] clip: run through Lindent Stephen Hemminger
2006-04-13 22:24   ` [PATCH 4/4] clip: add module info Stephen Hemminger
2006-04-13 22:45   ` [stable] [PATCH 1/4] clip: run through Lindent Greg KH
2006-04-14  9:01     ` David S. Miller
2006-04-14 22:58   ` David S. Miller
2006-04-14 22:59   ` David S. Miller
     [not found] ` <20060413151945.0f181d04@localhost.localdomain>
2006-04-13 22:23   ` [PATCH 3/4] clip: notifier related cleanups Stephen Hemminger
2006-04-13 22:23   ` Stephen Hemminger [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20060413152315.05051c08@localhost.localdomain \
    --to=shemminger@osdl.org \
    --cc=chas@cmf.nrl.navy.mil \
    --cc=davem@davemloft.net \
    --cc=linux-atm-general@lists.sourceforge.net \
    --cc=netdev@vger.kernel.org \
    --cc=stable@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).