From: Roger Luethi <rl@hellgate.ch>
To: "John W. Linville" <linville@tuxdriver.com>
Cc: Marco Berizzi <pupilla@hotmail.com>, netdev@vger.kernel.org
Subject: Re: via_rhine modules error on 2.6.16 with mii-tool
Date: Thu, 13 Apr 2006 22:31:48 +0200 [thread overview]
Message-ID: <20060413203147.GA2874@k3.hellgate.ch> (raw)
In-Reply-To: <20060413182638.GC25854@tuxdriver.com>
On Thu, 13 Apr 2006 14:26:43 -0400, John W. Linville wrote:
> > I wonder if low latency for ancient Rhine-I chips is worth the trouble.
>
> IIRC, the point was that mdelay was getting called in interrupt
> context and causing ugly messages to show-up in dmesg.
I suppose the patch back then was to reduce latency; the ugly messages in
the kernel ring buffer were _introduced_ with the patch (you shouldn't get
error messages calling mdelay in interrupt context because that's what
mdelay is for).
> Would the patch below be sufficient? Or does the whole patch need
> to be reverted?
I'd revert the whole thing. There's no point in having the additional
work_struct complexity if we end up calling mdelay anyway.
Roger
next prev parent reply other threads:[~2006-04-13 20:32 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <BAY103-F401F96F0B06D75E70AF0BFB2DF0@phx.gbl>
[not found] ` <20060327203946.GA11824@k3.hellgate.ch>
2006-04-13 18:26 ` via_rhine modules error on 2.6.16 with mii-tool John W. Linville
2006-04-13 18:40 ` Stephen Hemminger
2006-04-13 20:47 ` Roger Luethi
2006-04-13 21:02 ` Stephen Hemminger
2006-04-13 21:36 ` Francois Romieu
2006-04-13 21:55 ` Roger Luethi
2006-04-13 20:31 ` Roger Luethi [this message]
2006-05-19 14:41 ` [patch] via-rhine: revert "change mdelay to msleep and remove from ISR path" John W. Linville
2006-05-19 14:51 ` [patch w/o fuzz] " John W. Linville
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060413203147.GA2874@k3.hellgate.ch \
--to=rl@hellgate.ch \
--cc=linville@tuxdriver.com \
--cc=netdev@vger.kernel.org \
--cc=pupilla@hotmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).