Re: [PATCH] bcm43xx: iw_priv_args names should be <16 characters

[Erik Mouw <erik@harddisk-recovery.com>]

On Thu, Apr 13, 2006 at 10:29:19AM -0700, Stephen Hemminger wrote:
> On Thu, 13 Apr 2006 15:02:27 +0200
> Erik Mouw <erik@harddisk-recovery.com> wrote:
> 
> > The room for the names in bcm43xx_priv_wx_args[] are IFNAMSIZ long and
> > IFNAMSIZ is defined as 16, so the names in bcm43xx_priv_wx_args should
> > be 15 characters (16 including the trailing \0). This patch fixes that
> > for the "set_shortpreambl", "get_shortpreambl", "set_swencryption", and
> > "get_swencryption" private calls. Patch is against 2.6.17-rc1.
> > 
> > Signed-off-by: Erik Mouw <erik@harddisk-recovery.com>
> 
> Shouldn't compiler have gagged on this?

Apparently not. At least the compiler I use doesn't warn about it (gcc
version 3.3.5 (Debian 1:3.3.5-13)).

Linus, this might be be something for sparse to check:

  struct mystruct {
	char name[16];
  };

  mystruct ms = { .name = "muchlongerthan16characters" };


Erik

-- 
+-- Erik Mouw -- www.harddisk-recovery.com -- +31 70 370 12 90 --
| Lab address: Delftechpark 26, 2628 XH, Delft, The Netherlands