[RFC: 2.6 patch] net/irda/irias_object.c: remove unused exports

[RFC: 2.6 patch] net/irda/irias_object.c: remove unused exports

[Adrian Bunk]

This patch removes the following unused EXPORT_SYMBOL's:
- irias_find_attrib
- irias_new_string_value
- irias_new_octseq_value

Signed-off-by: Adrian Bunk <bunk@stusta.de>

---

 net/irda/irias_object.c |    3 ---
 1 file changed, 3 deletions(-)

--- linux-2.6.17-rc1-mm2-full/net/irda/irias_object.c.old	2006-04-14 12:37:49.000000000 +0200
+++ linux-2.6.17-rc1-mm2-full/net/irda/irias_object.c	2006-04-14 12:39:26.000000000 +0200
@@ -257,7 +257,6 @@
 	/* Unsafe (locking), attrib might change */
 	return attrib;
 }
-EXPORT_SYMBOL(irias_find_attrib);
 
 /*
  * Function irias_add_attribute (obj, attrib)
@@ -484,7 +483,6 @@
 
 	return value;
 }
-EXPORT_SYMBOL(irias_new_string_value);
 
 /*
  * Function irias_new_octseq_value (octets, len)
@@ -519,7 +517,6 @@
 	memcpy(value->t.oct_seq, octseq , len);
 	return value;
 }
-EXPORT_SYMBOL(irias_new_octseq_value);
 
 struct ias_value *irias_new_missing_value(void)
 {

Re: [RFC: 2.6 patch] net/irda/irias_object.c: remove unused exports

[Jean Tourrilhes]

	Hi,

	You now need to send those patches to :
		Samuel.Ortiz@nokia.com
	Personally, I don't see what this patch buy us...

	Jean

On Fri, Apr 14, 2006 at 01:44:46PM +0200, Adrian Bunk wrote:
> This patch removes the following unused EXPORT_SYMBOL's:
> - irias_find_attrib
> - irias_new_string_value
> - irias_new_octseq_value
> 
> Signed-off-by: Adrian Bunk <bunk@stusta.de>
> 
> ---
> 
>  net/irda/irias_object.c |    3 ---
>  1 file changed, 3 deletions(-)
> 
> --- linux-2.6.17-rc1-mm2-full/net/irda/irias_object.c.old	2006-04-14 12:37:49.000000000 +0200
> +++ linux-2.6.17-rc1-mm2-full/net/irda/irias_object.c	2006-04-14 12:39:26.000000000 +0200
> @@ -257,7 +257,6 @@
>  	/* Unsafe (locking), attrib might change */
>  	return attrib;
>  }
> -EXPORT_SYMBOL(irias_find_attrib);
>  
>  /*
>   * Function irias_add_attribute (obj, attrib)
> @@ -484,7 +483,6 @@
>  
>  	return value;
>  }
> -EXPORT_SYMBOL(irias_new_string_value);
>  
>  /*
>   * Function irias_new_octseq_value (octets, len)
> @@ -519,7 +517,6 @@
>  	memcpy(value->t.oct_seq, octseq , len);
>  	return value;
>  }
> -EXPORT_SYMBOL(irias_new_octseq_value);
>  
>  struct ias_value *irias_new_missing_value(void)
>  {
> 

Re: [RFC: 2.6 patch] net/irda/irias_object.c: remove unused exports

[Adrian Bunk]

On Fri, Apr 14, 2006 at 09:42:03AM -0700, Jean Tourrilhes wrote:

> 	Hi,

Hi Jean,

> 	You now need to send those patches to :
> 		Samuel.Ortiz@nokia.com

Samuel, please send a patch to update MAINTAINERS.

> 	Personally, I don't see what this patch buy us...

It makes the kernel image smaller.

> 	Jean

cu
Adrian

-- 

       "Is there not promise of rain?" Ling Tan asked suddenly out
        of the darkness. There had been need of rain for many days.
       "Only a promise," Lao Er said.
                                       Pearl S. Buck - Dragon Seed

Re: [RFC: 2.6 patch] net/irda/irias_object.c: remove unused exports

[Samuel Ortiz]

On Fri, 14 Apr 2006, ext Adrian Bunk wrote:

> On Fri, Apr 14, 2006 at 09:42:03AM -0700, Jean Tourrilhes wrote:
>
> > 	Hi,
>
> Hi Jean,
>
> > 	You now need to send those patches to :
> > 		Samuel.Ortiz@nokia.com
>
> Samuel, please send a patch to update MAINTAINERS.
Will do.

>
> > 	Personally, I don't see what this patch buy us...
>
> It makes the kernel image smaller.
It's not a lot, but it does make the kernel image smaller.
Those 3 symbols do not need to be exported as they are not used anywhere
in the modularized parts of the IrDA stack. So, the patch looks good to
me.

Cheers,
Samuel.

> > 	Jean
>
> cu
> Adrian
>
> --
>
>        "Is there not promise of rain?" Ling Tan asked suddenly out
>         of the darkness. There had been need of rain for many days.
>        "Only a promise," Lao Er said.
>                                        Pearl S. Buck - Dragon Seed
>
>

Re: [RFC: 2.6 patch] net/irda/irias_object.c: remove unused exports

[Arjan van de Ven]

> 	Personally, I don't see what this patch buy us...

all the unused exports in the kernel together make a binary kernel 100Kb
bigger. It's a case of a lot of little steps I suppose (each export
taking like 100 to 150 bytes depending on the size of the function name)

Re: [RFC: 2.6 patch] net/irda/irias_object.c: remove unused exports

[Alan Cox]

On Sul, 2006-04-16 at 19:46 +0200, Arjan van de Ven wrote:
> > 	Personally, I don't see what this patch buy us...
> 
> all the unused exports in the kernel together make a binary kernel 100Kb
> bigger. It's a case of a lot of little steps I suppose (each export
> taking like 100 to 150 bytes depending on the size of the function name)


So why are exports taking us 100-150 bytes, not say 20 which is what I'd
expect ?

Re: [RFC: 2.6 patch] net/irda/irias_object.c: remove unused exports

[Arjan van de Ven]

On Sun, 2006-04-16 at 19:37 +0100, Alan Cox wrote:
> On Sul, 2006-04-16 at 19:46 +0200, Arjan van de Ven wrote:
> > > 	Personally, I don't see what this patch buy us...
> > 
> > all the unused exports in the kernel together make a binary kernel 100Kb
> > bigger. It's a case of a lot of little steps I suppose (each export
> > taking like 100 to 150 bytes depending on the size of the function name)
> 
> 
> So why are exports taking us 100-150 bytes, not say 20 which is what I'd
> expect ?

there is the name, the crc, the address, a module name thingy (which I
think is only filled for non-built-in symbols) and I'm sure there's some
padding here and there... 

About 1/3rd of all exports is unused, so killing those is an easy way to
gain back the space...

Re: [RFC: 2.6 patch] net/irda/irias_object.c: remove unused exports

[Samuel Ortiz]

On Fri, 14 Apr 2006, ext Adrian Bunk wrote:

> This patch removes the following unused EXPORT_SYMBOL's:
> - irias_find_attrib
> - irias_new_string_value
> - irias_new_octseq_value
>
> Signed-off-by: Adrian Bunk <bunk@stusta.de>
Looks good to me.

Signed-off-by: Samuel Ortiz <samuel.ortiz@nokia.com>


> ---
>
>  net/irda/irias_object.c |    3 ---
>  1 file changed, 3 deletions(-)
>
> --- linux-2.6.17-rc1-mm2-full/net/irda/irias_object.c.old	2006-04-14 12:37:49.000000000 +0200
> +++ linux-2.6.17-rc1-mm2-full/net/irda/irias_object.c	2006-04-14 12:39:26.000000000 +0200
> @@ -257,7 +257,6 @@
>  	/* Unsafe (locking), attrib might change */
>  	return attrib;
>  }
> -EXPORT_SYMBOL(irias_find_attrib);
>
>  /*
>   * Function irias_add_attribute (obj, attrib)
> @@ -484,7 +483,6 @@
>
>  	return value;
>  }
> -EXPORT_SYMBOL(irias_new_string_value);
>
>  /*
>   * Function irias_new_octseq_value (octets, len)
> @@ -519,7 +517,6 @@
>  	memcpy(value->t.oct_seq, octseq , len);
>  	return value;
>  }
> -EXPORT_SYMBOL(irias_new_octseq_value);
>
>  struct ias_value *irias_new_missing_value(void)
>  {
>
> -
> To unsubscribe from this list: send the line "unsubscribe netdev" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
>

Re: [RFC: 2.6 patch] net/irda/irias_object.c: remove unused exports

[David S. Miller]

From: Samuel Ortiz <samuel.ortiz@nokia.com>
Date: Sat, 15 Apr 2006 11:58:21 +0300 (EEST)

> On Fri, 14 Apr 2006, ext Adrian Bunk wrote:
> 
> > This patch removes the following unused EXPORT_SYMBOL's:
> > - irias_find_attrib
> > - irias_new_string_value
> > - irias_new_octseq_value
> >
> > Signed-off-by: Adrian Bunk <bunk@stusta.de>
> Looks good to me.
> 
> Signed-off-by: Samuel Ortiz <samuel.ortiz@nokia.com>

Sam, just add this to your IRDA queue.  Ok?

Re: [RFC: 2.6 patch] net/irda/irias_object.c: remove unused exports

[Samuel Ortiz]

On Sat, 15 Apr 2006, ext David S. Miller wrote:

> From: Samuel Ortiz <samuel.ortiz@nokia.com>
> Date: Sat, 15 Apr 2006 11:58:21 +0300 (EEST)
>
> > On Fri, 14 Apr 2006, ext Adrian Bunk wrote:
> >
> > > This patch removes the following unused EXPORT_SYMBOL's:
> > > - irias_find_attrib
> > > - irias_new_string_value
> > > - irias_new_octseq_value
> > >
> > > Signed-off-by: Adrian Bunk <bunk@stusta.de>
> > Looks good to me.
> >
> > Signed-off-by: Samuel Ortiz <samuel.ortiz@nokia.com>
>
> Sam, just add this to your IRDA queue.  Ok?
Sure, I will.