From: Christoph Hellwig <hch@lst.de>
To: Martin Diehl <info@mdiehl.de>
Cc: Christoph Hellwig <hch@lst.de>, Jean Tourrilhes <jt@hpl.hp.com>,
netdev@vger.kernel.org
Subject: Re: [PATCH] sir: switch to a workqueue
Date: Sat, 15 Apr 2006 18:37:12 +0200 [thread overview]
Message-ID: <20060415163712.GA13342@lst.de> (raw)
In-Reply-To: <Pine.LNX.4.44.0604151444521.19061-100000@notebook.home.mdiehl.de>
On Sat, Apr 15, 2006 at 04:24:15PM +0200, Martin Diehl wrote:
>
> My only concern with this patch is this:
<..>
> Hm, queue_work might fail (like it was possible with irda_queue_request),
> if work->pending is set. In that case, chances are we have a partially
> configured irda device dangling around. The idea was to (re-)enable rx and
> restore the xmit queue state on netdev so we can rely on the upper layers
> to recover. I think without the fallback the netdev might become unuseable
> until ifdown/ifup-cycle, if queue_work would ever fail.
queue_work doesn't fail if work->pending, it just noticed this
particular work_Struct is already beeing serviced and tells you that.
In the sir code that can't happen because the work_struct has ben
allocated and initialized a few lines above, so there's zero chance for
someone else to call queue_work on it concurrently.
prev parent reply other threads:[~2006-04-15 16:37 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-04-14 18:20 [PATCH] sir: switch to a workqueue Christoph Hellwig
2006-04-14 18:22 ` Jean Tourrilhes
[not found] ` <Pine.LNX.4.44.0604151444521.19061-100000@notebook.home.mdiehl.de>
2006-04-15 16:37 ` Christoph Hellwig [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060415163712.GA13342@lst.de \
--to=hch@lst.de \
--cc=info@mdiehl.de \
--cc=jt@hpl.hp.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).