From: Stephen Hemminger <shemminger@osdl.org>
To: Zhu Yi <yi.zhu@intel.com>
Cc: netdev@vger.kernel.org, "John W. Linville" <linville@tuxdriver.com>
Subject: Re: [PATCH] ipw2100: wraps the debug module param within #ifdefs
Date: Mon, 17 Apr 2006 09:24:45 -0700 [thread overview]
Message-ID: <20060417092445.22952efa@localhost.localdomain> (raw)
In-Reply-To: <1145240263.968.203.camel@debian.sh.intel.com>
On Mon, 17 Apr 2006 10:17:43 +0800
Zhu Yi <yi.zhu@intel.com> wrote:
> On Fri, 2006-04-14 at 09:33 -0700, Stephen Hemminger wrote:
> > I meant get rid of CONFIG_IPW2200_DEBUG completely. Having the debug code isn't
> > bad, and there is no reason not to have it always there.
>
> There are lots of IPW_DEBUG_XXX in the driver, even in TX and RX paths.
> It cause extra cycles for those who really don't need it.
>
> Thanks,
> -yi
IMHO. There is never a reason for a driver specific config option for debugging.
Either it the debug option is generally useful for support (ie distro's will want it on),
in which case the debugging should be runtime settable but always available;
or the debug option is so meant for the driver developers in which case it should
be enabled by a source modification (see #define DEBUG and pr_debug).
But, those are opinions only and certainly, you can do what you want with your
driver.
prev parent reply other threads:[~2006-04-17 16:24 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-04-13 9:14 [PATCH] ipw2100: wraps the debug module param within #ifdefs Zhu Yi
2006-04-13 17:30 ` Stephen Hemminger
2006-04-14 5:18 ` Zhu Yi
2006-04-14 16:33 ` Stephen Hemminger
2006-04-17 2:17 ` Zhu Yi
2006-04-17 16:24 ` Stephen Hemminger [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060417092445.22952efa@localhost.localdomain \
--to=shemminger@osdl.org \
--cc=linville@tuxdriver.com \
--cc=netdev@vger.kernel.org \
--cc=yi.zhu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).