From: Stephen Hemminger <shemminger@osdl.org>
To: Herbert Xu <herbert@gondor.apana.org.au>
Cc: davem@davemloft.net, netdev@vger.kernel.org
Subject: Re: [PATCH] ip_route_input panic fix
Date: Mon, 17 Apr 2006 19:49:31 -0700 [thread overview]
Message-ID: <20060417194931.032aba02@localhost.localdomain> (raw)
In-Reply-To: <E1FVfxQ-0008Tf-00@gondolin.me.apana.org.au>
On Tue, 18 Apr 2006 12:28:48 +1000
Herbert Xu <herbert@gondor.apana.org.au> wrote:
> Hi Stephen:
>
> Stephen Hemminger <shemminger@osdl.org> wrote:
> > This fixes http://bugzilla.kernel.org/show_bug.cgi?id=6388
> > The bug is caused by ip_route_input dereferencing skb->nh.protocol of
> > the dummy skb passed dow from inet_rtm_getroute (Thanks Thomas for seeing
> > it). It only happens if the route requested is for a multicast IP
> > address.
>
> Good catch.
>
> > - skb->mac.raw = skb->data;
> > + skb->mac.raw = skb->nh.raw = skb->data;
>
> This should fix it.
>
> > + /* Bugfix: need to give ip_route_input enough of an IP header to not gag. */
> > + skb->nh.iph->protocol = IPPROTO_ICMP;
>
> Do we really need this? After all we can get completely bogus values
> coming in through the network too.
Not really, just that ip_check_mc looks at the proto for !IGMP. And maybe
some tool like coverity or sparse would be smart enough to look for
uninitialized data usage.
next prev parent reply other threads:[~2006-04-18 2:49 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-04-18 0:12 [PATCH] ip_route_input panic fix Stephen Hemminger
2006-04-18 2:28 ` Herbert Xu
2006-04-18 2:49 ` Stephen Hemminger [this message]
2006-04-18 2:54 ` Herbert Xu
2006-04-18 5:45 ` David S. Miller
2006-04-18 6:54 ` Herbert Xu
2006-04-18 21:54 ` David S. Miller
2006-04-18 22:08 ` Herbert Xu
2006-04-18 23:52 ` Alexey Kuznetsov
2006-04-19 0:17 ` Herbert Xu
2006-04-19 3:53 ` David S. Miller
2006-04-19 9:46 ` Alexey Kuznetsov
-- strict thread matches above, loose matches on Subject: below --
2006-04-19 0:59 Alexey Kuznetsov
2006-04-19 1:00 Alexey Kuznetsov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060417194931.032aba02@localhost.localdomain \
--to=shemminger@osdl.org \
--cc=davem@davemloft.net \
--cc=herbert@gondor.apana.org.au \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).