From: "David S. Miller" <davem@davemloft.net>
To: netdev@axxeo.de
Cc: herbert@gondor.apana.org.au, bb@kernelpanic.ru,
kernel@linuxace.com, nipsy@bitgnome.net,
jesse.brandeburg@intel.com, jrlundgren@gmail.com, cat@zip.com.au,
djani22@dynamicweb.hu, yoseph.basri@gmail.com, mykleb@no.ibm.com,
olel@ans.pl, michal@feix.cz, chris@scorpion.nl,
netdev@vger.kernel.org, jesse.brandeburg@gmail.com, ak@suse.de,
jgarzik@pobox.com
Subject: Re: [TCP]: Fix truesize underflow
Date: Tue, 18 Apr 2006 13:19:48 -0700 (PDT) [thread overview]
Message-ID: <20060418.131948.25497627.davem@davemloft.net> (raw)
In-Reply-To: <200604181829.59686.netdev@axxeo.de>
From: Ingo Oeser <netdev@axxeo.de>
Date: Tue, 18 Apr 2006 18:29:59 +0200
> But shouldn't we put this kind of hairy manipulation into some nice
> functions? Driver writers were already confused by all that size,
> len and truesize stuff, as this bug showed.
It's 2 lines and frankly it's a bit context dependant. I think
Herbert's fix is fine for now.
In the long term, yes, a lot of these weird manipulations need to
be consolidated in well defined functions to make maintainence
and auditing easier.
next prev parent reply other threads:[~2006-04-18 20:20 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-04-18 12:32 [TCP]: Fix truesize underflow Herbert Xu
2006-04-18 16:29 ` Ingo Oeser
2006-04-18 20:19 ` David S. Miller [this message]
2006-04-18 20:22 ` David S. Miller
2006-04-18 23:27 ` Herbert Xu
2006-04-19 6:04 ` Boris B. Zhmurov
2006-04-19 6:40 ` Herbert Xu
2006-04-19 16:07 ` Jesse Brandeburg
2006-04-19 21:29 ` Krzysztof Oledzki
2006-04-19 16:53 ` Stephen Hemminger
2006-04-19 20:07 ` David S. Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060418.131948.25497627.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=ak@suse.de \
--cc=bb@kernelpanic.ru \
--cc=cat@zip.com.au \
--cc=chris@scorpion.nl \
--cc=djani22@dynamicweb.hu \
--cc=herbert@gondor.apana.org.au \
--cc=jesse.brandeburg@gmail.com \
--cc=jesse.brandeburg@intel.com \
--cc=jgarzik@pobox.com \
--cc=jrlundgren@gmail.com \
--cc=kernel@linuxace.com \
--cc=michal@feix.cz \
--cc=mykleb@no.ibm.com \
--cc=netdev@axxeo.de \
--cc=netdev@vger.kernel.org \
--cc=nipsy@bitgnome.net \
--cc=olel@ans.pl \
--cc=yoseph.basri@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).