netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "David S. Miller" <davem@davemloft.net>
To: borntrae@de.ibm.com
Cc: akpm@osdl.org, heiko.carstens@de.ibm.com, shemminger@osdl.org,
	jgarzik@pobox.com, netdev@vger.kernel.org,
	linux-kernel@vger.kernel.org, fpavlic@de.ibm.com,
	davem@sunset.davemloft.net
Subject: Re: [patch] ipv4: initialize arp_tbl rw lock
Date: Wed, 19 Apr 2006 13:12:37 -0700 (PDT)	[thread overview]
Message-ID: <20060419.131237.49371772.davem@davemloft.net> (raw)
In-Reply-To: <200604191245.48458.borntrae@de.ibm.com>

From: Christian Borntraeger <borntrae@de.ibm.com>
Date: Wed, 19 Apr 2006 12:45:48 +0200

> As spinlock debugging still does not work with the qeth driver I
> want to pick up the discussion.

Does something like the patch below work?

But this all begs the question, what happens if you want to
dig into the internals of a protocol which is built modular and
hasn't been loaded yet?

diff --git a/include/linux/init.h b/include/linux/init.h
index 93dcbe1..8169f25 100644
--- a/include/linux/init.h
+++ b/include/linux/init.h
@@ -95,8 +95,9 @@ #define postcore_initcall(fn)		__define_
 #define arch_initcall(fn)		__define_initcall("3",fn)
 #define subsys_initcall(fn)		__define_initcall("4",fn)
 #define fs_initcall(fn)			__define_initcall("5",fn)
-#define device_initcall(fn)		__define_initcall("6",fn)
-#define late_initcall(fn)		__define_initcall("7",fn)
+#define net_initcall(fn)		__define_initcall("6",fn)
+#define device_initcall(fn)		__define_initcall("7",fn)
+#define late_initcall(fn)		__define_initcall("8",fn)
 
 #define __initcall(fn) device_initcall(fn)
 
diff --git a/net/ipv4/af_inet.c b/net/ipv4/af_inet.c
index dc206f1..9803a57 100644
--- a/net/ipv4/af_inet.c
+++ b/net/ipv4/af_inet.c
@@ -1257,7 +1257,7 @@ out_unregister_udp_proto:
 	goto out;
 }
 
-module_init(inet_init);
+net_initcall(inet_init);
 
 /* ------------------------------------------------------------------------ */
 

  reply	other threads:[~2006-04-19 20:12 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-04-07  8:15 [patch] ipv4: initialize arp_tbl rw lock Heiko Carstens
2006-04-07 14:46 ` Stephen Hemminger
2006-04-08 10:02   ` Heiko Carstens
2006-04-08 10:12     ` Andrew Morton
2006-04-19 10:45       ` Christian Borntraeger
2006-04-19 20:12         ` David S. Miller [this message]
2006-04-20 13:11           ` Heiko Carstens
2006-04-08 10:14     ` David S. Miller
2006-04-08 10:42       ` Heiko Carstens
2006-04-08 12:14       ` Sam Ravnborg
2006-04-15  7:27       ` Heiko Carstens
2006-04-15  7:34         ` David S. Miller
2006-04-15 23:00           ` Heiko Carstens
2006-04-24 10:18           ` Heiko Carstens
2006-04-24 10:22           ` [patch] ipv4: inet_init() -> fs_initcall Heiko Carstens
2006-04-07 20:14 ` [patch] ipv4: initialize arp_tbl rw lock David S. Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20060419.131237.49371772.davem@davemloft.net \
    --to=davem@davemloft.net \
    --cc=akpm@osdl.org \
    --cc=borntrae@de.ibm.com \
    --cc=davem@sunset.davemloft.net \
    --cc=fpavlic@de.ibm.com \
    --cc=heiko.carstens@de.ibm.com \
    --cc=jgarzik@pobox.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=shemminger@osdl.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).