netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "David S. Miller" <davem@davemloft.net>
To: michaelc@cs.wisc.edu
Cc: netdev@vger.kernel.org
Subject: Re: sendpage and high mem pages
Date: Thu, 20 Apr 2006 12:35:43 -0700 (PDT)	[thread overview]
Message-ID: <20060420.123543.113480414.davem@davemloft.net> (raw)
In-Reply-To: <4447E102.5080203@cs.wisc.edu>

From: Mike Christie <michaelc@cs.wisc.edu>
Date: Thu, 20 Apr 2006 14:29:06 -0500

> I was wondering if it is ok to pass sendpage high mem pages. If a piece
> of code does this:
> 
> struct socket *sock;
> 
> sock->ops->sendpage(pg...)
> 
> and pg is a highmem page will the network layer do the right thing or
> should the caller check the page type and call sock_no_sendpage() for
> highmen? It looks like net/sunrpc/xprtsock.c does a check but
> drivers/scsi/iscsi_tcp.c and some others do not.

TCP and others handle this just fine, if something doesn't then it
needs to be fixed.  Any page in the page cache can be sent over this
interface.

      reply	other threads:[~2006-04-20 19:35 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-04-20 19:29 sendpage and high mem pages Mike Christie
2006-04-20 19:35 ` David S. Miller [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20060420.123543.113480414.davem@davemloft.net \
    --to=davem@davemloft.net \
    --cc=michaelc@cs.wisc.edu \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).