From: Jiri Benc <jbenc@suse.cz>
To: Stephen Hemminger <shemminger@osdl.org>
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH 9/10] d80211: rename master interface
Date: Fri, 21 Apr 2006 23:06:47 +0200 [thread overview]
Message-ID: <20060421230647.34541657@griffin.suse.cz> (raw)
In-Reply-To: <20060421140254.65fe7d29@localhost.localdomain>
On Fri, 21 Apr 2006 14:02:54 -0700, Stephen Hemminger wrote:
> On Fri, 21 Apr 2006 22:53:29 +0200 (CEST)
> Jiri Benc <jbenc@suse.cz> wrote:
> > - memcpy(mdev->name, "wlan%d", 7);
> > + memcpy(mdev->name, "wmaster%d", 10);
>
> Why not use strlcpy or strncpy? and use sizeof(mdev->name) or IFNAMSIZ
> rather than hard coded 10.
Good idea :-) Will fix it, thanks.
Jiri
--
Jiri Benc
SUSE Labs
next prev parent reply other threads:[~2006-04-21 21:06 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-04-21 20:53 [PATCH 0/10] d80211: bugfixes and reducing number of interfaces Jiri Benc
2006-04-21 20:53 ` [PATCH 1/10] d80211: fix SIOCGIWESSID ioctl Jiri Benc
2006-04-21 20:53 ` [PATCH 2/10] d80211: use is_multicast_ether_addr Jiri Benc
2006-04-21 20:53 ` [PATCH 3/10] d80211: fix Oops caused by packets sent directly to master device Jiri Benc
2006-04-21 20:53 ` [PATCH 4/10] d80211: don't use pointer in ieee80211_tx_control Jiri Benc
2006-04-21 20:53 ` [PATCH 5/10] d80211: per-interface SSID Jiri Benc
2006-04-21 20:53 ` [PATCH 6/10] d80211: per-interface generic_elem Jiri Benc
2006-04-21 20:53 ` [PATCH 7/10] d80211: get rid of default AP interface Jiri Benc
2006-04-21 20:53 ` [PATCH 8/10] d80211: get rid of default management interface Jiri Benc
2006-04-21 20:59 ` Johannes Berg
2006-04-21 21:03 ` Jiri Benc
2006-04-22 2:44 ` Jouni Malinen
2006-04-24 13:01 ` Jiri Benc
2006-04-26 18:53 ` John W. Linville
2006-04-21 20:53 ` [PATCH 9/10] d80211: rename master interface Jiri Benc
2006-04-21 21:02 ` Stephen Hemminger
2006-04-21 21:06 ` Jiri Benc [this message]
2006-04-21 20:53 ` [PATCH 10/10] d80211: add one default interface Jiri Benc
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060421230647.34541657@griffin.suse.cz \
--to=jbenc@suse.cz \
--cc=netdev@vger.kernel.org \
--cc=shemminger@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).