From: "David S. Miller" <davem@davemloft.net>
To: herbert@gondor.apana.org.au
Cc: jgarzik@pobox.com, auke-jan.h.kok@intel.com,
netdev@vger.kernel.org, john.ronciak@intel.com,
jesse.brandeburg@intel.com, Jeffrey.t.kirsher@intel.com,
auke@foo-projects.org
Subject: Re: [PATCH 00/10] e1000: Driver fixes and update to 7.0.38-k2
Date: Sat, 22 Apr 2006 22:53:45 -0700 (PDT) [thread overview]
Message-ID: <20060422.225345.125621531.davem@davemloft.net> (raw)
In-Reply-To: <E1FXAa6-0001Wt-00@gondolin.me.apana.org.au>
From: Herbert Xu <herbert@gondor.apana.org.au>
Date: Sat, 22 Apr 2006 15:22:54 +1000
> Jeff Garzik <jgarzik@pobox.com> wrote:
> >
> >> 05/10: [PATCH] Update truesize with the length of the packet for
> >> packet split
> >
> > These 10 patches look OK, but since the current kernel version is
> > 2.6.17-rc1, that means we are in "bug fix only" mode right now.
> >
> > Should I (a) apply these all to netdev2-.6.git#upstream, queueing them
> > for 2.6.18, or (b) let you split the submission into two parts, bug
> > fixes only and everything else?
>
> It turns out that the truesize patch is pretty important as otherwise
> most of TCP receive socket buffer accounting falls apart. So it should
> probably go into 2.6.17 and even 2.6.16-stable.
I totally agree.
Jeff please try to get at least this skb->truesize fix queued
to both -stable and current 2.6.x, it's really needed and
important for proper socket memory accounting on receive with
e1000.
Thanks.
next prev parent reply other threads:[~2006-04-23 5:53 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-04-14 18:34 [PATCH 00/10] e1000: Driver fixes and update to 7.0.38-k2 Kok, Auke
2006-04-14 18:36 ` [PATCH 01/10] e1000: Remove PM warning DPRINTKs breaking 2.4.x kernels Kok, Auke
2006-04-14 18:36 ` [PATCH 02/10] e1000: Esb2 wol link cycle bug and uninitialized registers Kok, Auke
2006-04-14 18:36 ` [PATCH 03/10] e1000: De-inline functions to benefit from compiler smartness Kok, Auke
2006-04-14 18:36 ` [PATCH 04/10] e1000: Made an adapter struct variable into a local (txb2b) Kok, Auke
2006-04-14 18:36 ` [PATCH 05/10] e1000: Update truesize with the length of the packet for packet split Kok, Auke
2006-04-14 21:16 ` Jeff Garzik
2006-04-14 22:13 ` Jesse Brandeburg
2006-04-14 22:32 ` David S. Miller
2006-04-14 22:43 ` Jesse Brandeburg
2006-04-14 22:51 ` David S. Miller
2006-04-14 23:04 ` Jesse Brandeburg
2006-04-14 23:45 ` David S. Miller
2006-04-14 23:52 ` Jesse Brandeburg
2006-04-14 18:37 ` [PATCH 06/10] e1000: Dead variable cleanup Kok, Auke
2006-04-14 18:37 ` [PATCH 07/10] e1000: Buffer optimizations for small MTU Kok, Auke
2006-04-14 18:37 ` [PATCH 08/10] e1000: implement more efficient tx queue locking Kok, Auke
2006-04-14 18:37 ` [PATCH 09/10] e1000: Version bump, contact fix, year string change Kok, Auke
2006-04-14 18:37 ` [PATCH 10/10] {e100{,0},ixgb}: Add Auke Kok as new patch maintainer for e{100,1000} and ixgb Kok, Auke
2006-04-14 19:01 ` [PATCH 00/10] e1000: Driver fixes and update to 7.0.38-k2 Jeff Garzik
2006-04-14 19:32 ` Auke Kok
2006-04-22 5:22 ` Herbert Xu
2006-04-23 5:53 ` David S. Miller [this message]
2006-04-23 14:13 ` Auke Kok
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060422.225345.125621531.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=Jeffrey.t.kirsher@intel.com \
--cc=auke-jan.h.kok@intel.com \
--cc=auke@foo-projects.org \
--cc=herbert@gondor.apana.org.au \
--cc=jesse.brandeburg@intel.com \
--cc=jgarzik@pobox.com \
--cc=john.ronciak@intel.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).