From: Stephen Hemminger <shemminger@osdl.org>
To: Francois Romieu <romieu@fr.zoreil.com>
Cc: Ananda Raju <Ananda.Raju@neterion.com>,
jgarzik@pobox.com, netdev@vger.kernel.org,
leonid.grossman@neterion.com, ravinandan.arakali@neterion.com,
rapuru.sriram@neterion.com, alicia.pena@neterion.com
Subject: Re: [patch 2/5] s2io driver updates
Date: Mon, 24 Apr 2006 10:22:03 -0700 [thread overview]
Message-ID: <20060424102203.3cb5e29b@localhost.localdomain> (raw)
In-Reply-To: <20060422092802.GD26666@electric-eye.fr.zoreil.com>
On Sat, 22 Apr 2006 11:28:02 +0200
Francois Romieu <romieu@fr.zoreil.com> wrote:
> Ananda Raju <Ananda.Raju@neterion.com> :
> [...]
> > Signed-off-by: Ananda Raju <ananda.raju@neterion.com>
> > ---
> > diff -upNr perf_fixes/drivers/net/s2io.c dmesg_param_fixes/drivers/net/s2io.c
> > --- perf_fixes/drivers/net/s2io.c 2006-04-13 08:02:56.000000000 -0700
> > +++ dmesg_param_fixes/drivers/net/s2io.c 2006-04-13 09:08:22.000000000 -0700
> [...]
> > @@ -4626,6 +4633,45 @@ static int write_eeprom(nic_t * sp, int
> > return ret;
> > }
> >
> > +static void s2io_vpd_read(nic_t *nic)
> > +{
> > + u8 vpd_data[256],data;
>
> You may consider removing vpd_data from the stack and kmallocing it.
>
Since there lsvpd tool doesn't in user space, why add more kernel code
to do it? Adding more code to just print prettier console log's is bogus.
next prev parent reply other threads:[~2006-04-24 17:22 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-04-21 23:05 [patch 2/5] s2io driver updates Ananda Raju
2006-04-22 9:28 ` Francois Romieu
2006-04-24 17:22 ` Stephen Hemminger [this message]
2006-04-24 17:39 ` Ananda Raju
2006-04-24 17:57 ` Stephen Hemminger
2006-04-24 18:20 ` Ananda Raju
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060424102203.3cb5e29b@localhost.localdomain \
--to=shemminger@osdl.org \
--cc=Ananda.Raju@neterion.com \
--cc=alicia.pena@neterion.com \
--cc=jgarzik@pobox.com \
--cc=leonid.grossman@neterion.com \
--cc=netdev@vger.kernel.org \
--cc=rapuru.sriram@neterion.com \
--cc=ravinandan.arakali@neterion.com \
--cc=romieu@fr.zoreil.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox