From: Stephen Hemminger <shemminger@osdl.org>
To: "David S. Miller" <davem@davemloft.net>
Cc: hzhong@gmail.com, netdev@vger.kernel.org
Subject: Re: [PATCH]: suspicious unlikely usage in tcp_transmit_skb()
Date: Tue, 25 Apr 2006 15:16:35 -0700 [thread overview]
Message-ID: <20060425151635.549d3400@localhost.localdomain> (raw)
In-Reply-To: <20060425.144649.129407913.davem@davemloft.net>
On Tue, 25 Apr 2006 14:46:49 -0700 (PDT)
"David S. Miller" <davem@davemloft.net> wrote:
> From: Stephen Hemminger <shemminger@osdl.org>
> Date: Tue, 25 Apr 2006 10:01:49 -0700
>
> > > # Hit # miss Function:Filename@Line
> > > ! 0 50505 tcp_transmit_skb():net/ipv4/tcp_output.c@468
> ...
> > How about just taking off the likely/unlikely in this case.
>
> Why remove it when we'll now get a 50505 to 0 hit rate?
Depends on the data stream, but I guess if we are seeing high loss
we really don't care about the CPU branch prediction.
next prev parent reply other threads:[~2006-04-25 22:16 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-04-24 23:25 [PATCH]: suspicious unlikely usage in tcp_transmit_skb() Hua Zhong
2006-04-25 5:34 ` Herbert Xu
2006-04-25 17:01 ` Stephen Hemminger
2006-04-25 21:46 ` David S. Miller
2006-04-25 22:16 ` Stephen Hemminger [this message]
2006-04-26 7:26 ` David S. Miller
2006-04-26 9:42 ` David S. Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060425151635.549d3400@localhost.localdomain \
--to=shemminger@osdl.org \
--cc=davem@davemloft.net \
--cc=hzhong@gmail.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).