From: "David S. Miller" <davem@davemloft.net>
To: hzhong@gmail.com
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH]: suspicious unlikely usage in tcp_transmit_skb()
Date: Wed, 26 Apr 2006 02:42:34 -0700 (PDT) [thread overview]
Message-ID: <20060426.024234.117307955.davem@davemloft.net> (raw)
In-Reply-To: <444D5E73.7020803@gmail.com>
From: Hua Zhong <hzhong@gmail.com>
Date: Mon, 24 Apr 2006 16:25:39 -0700
> Hi,
>
> I am developing a profiling tool to check if likely/unlikely usages are wise. I find that the following one is always a miss:
>
> # Hit # miss Function:Filename@Line
> ! 0 50505 tcp_transmit_skb():net/ipv4/tcp_output.c@468
>
> There is a chance that my tool is buggy, but I just want to confirm with you whether this does look suspicious and what your opinion is.
>
> Signed-off-by: Hua Zhong <hzhong@gmail.com>
Your patch is semantically correct but does not apply, because your
email client has turned all of the tab characters in the patch into
spaces. This corrupts the patch and makes it unusable.
This problem is hit by pretty much every single gmail user that tries
to send a patch for the first time. I wish gmail would not mangle
ascii text by default.
Please fix this and repost, retaining a proper changelog entry and
signed off line, thank you.
prev parent reply other threads:[~2006-04-26 9:42 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-04-24 23:25 [PATCH]: suspicious unlikely usage in tcp_transmit_skb() Hua Zhong
2006-04-25 5:34 ` Herbert Xu
2006-04-25 17:01 ` Stephen Hemminger
2006-04-25 21:46 ` David S. Miller
2006-04-25 22:16 ` Stephen Hemminger
2006-04-26 7:26 ` David S. Miller
2006-04-26 9:42 ` David S. Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060426.024234.117307955.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=hzhong@gmail.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).