From: "David S. Miller" <davem@davemloft.net>
To: shemminger@osdl.org
Cc: netdev@vger.kernel.org
Subject: Re: [RFC] bridge: partial rtnetlink hooks
Date: Wed, 26 Apr 2006 15:43:51 -0700 (PDT) [thread overview]
Message-ID: <20060426.154351.14477425.davem@davemloft.net> (raw)
In-Reply-To: <20060426104521.44682924@localhost.localdomain>
From: Stephen Hemminger <shemminger@osdl.org>
Date: Wed, 26 Apr 2006 10:45:21 -0700
> +struct brifinfo {
> + __u8 state;
> + __u32 cost;
> +};
> +
Maybe put the __u32 first and explicitly pad out the 3
bytes after the __u8? Just to be safe.
I know you use an assignment initializer, so your current
code won't leak kernel data into userspace, but a safer
layout might help provide even more protection for future
code using this data structure.
next prev parent reply other threads:[~2006-04-26 22:43 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-04-26 17:45 [RFC] bridge: partial rtnetlink hooks Stephen Hemminger
2006-04-26 22:24 ` Francois Romieu
2006-04-26 22:43 ` David S. Miller [this message]
2006-04-27 8:24 ` Patrick McHardy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060426.154351.14477425.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
--cc=shemminger@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).