Netdev List
 help / color / mirror / Atom feed
From: "David S. Miller" <davem@davemloft.net>
To: herbert@gondor.apana.org.au
Cc: netdev@vger.kernel.org
Subject: Re: [IPSEC]: Fix IP ID selection
Date: Fri, 28 Apr 2006 15:23:19 -0700 (PDT)	[thread overview]
Message-ID: <20060428.152319.58444954.davem@davemloft.net> (raw)
In-Reply-To: <20060427115645.GA20140@gondor.apana.org.au>

From: Herbert Xu <herbert@gondor.apana.org.au>
Date: Thu, 27 Apr 2006 21:56:45 +1000

> I was looking through the xfrm input/output code in order to abstract
> out the address family specific encapsulation/decapsulation code.  During
> that process I found this bug in the IP ID selection code in xfrm4_output.c.
> 
> At that point dst is still the xfrm_dst for the current SA which
> represents an internal flow as far as the IPsec tunnel is concerned.
> Since the IP ID is going to sit on the outside of the encapsulated
> packet, we obviously want the external flow which is just dst->child.
> 
> The fix is trivial.
> 
> Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>

Thanks for catching this, applied, thanks Herbert.

      reply	other threads:[~2006-04-28 22:23 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-04-27 11:56 [IPSEC]: Fix IP ID selection Herbert Xu
2006-04-28 22:23 ` David S. Miller [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20060428.152319.58444954.davem@davemloft.net \
    --to=davem@davemloft.net \
    --cc=herbert@gondor.apana.org.au \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox