* [PATCH] netem: fix loss
@ 2006-04-28 17:22 Stephen Hemminger
2006-04-28 19:12 ` David S. Miller
0 siblings, 1 reply; 2+ messages in thread
From: Stephen Hemminger @ 2006-04-28 17:22 UTC (permalink / raw)
To: David S. Miller; +Cc: netdev, George Nychis, netem
The following one line fix is needed to make loss function of
netem work right when doing loss on the local host.
Otherwise, higher layers just recover.
Signed-off-by: Stephen Hemminger <shemminger@osdl.org>
--- linux-2.6.orig/net/sched/sch_netem.c
+++ linux-2.6/net/sched/sch_netem.c
@@ -167,7 +167,7 @@ static int netem_enqueue(struct sk_buff
if (count == 0) {
sch->qstats.drops++;
kfree_skb(skb);
- return NET_XMIT_DROP;
+ return NET_XMIT_BYPASS;
}
/*
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] netem: fix loss
2006-04-28 17:22 [PATCH] netem: fix loss Stephen Hemminger
@ 2006-04-28 19:12 ` David S. Miller
0 siblings, 0 replies; 2+ messages in thread
From: David S. Miller @ 2006-04-28 19:12 UTC (permalink / raw)
To: shemminger; +Cc: netdev, gnychis, netem
From: Stephen Hemminger <shemminger@osdl.org>
Date: Fri, 28 Apr 2006 10:22:40 -0700
> The following one line fix is needed to make loss function of
> netem work right when doing loss on the local host.
> Otherwise, higher layers just recover.
>
> Signed-off-by: Stephen Hemminger <shemminger@osdl.org>
Applied, thanks Stephen.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2006-04-28 19:12 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2006-04-28 17:22 [PATCH] netem: fix loss Stephen Hemminger
2006-04-28 19:12 ` David S. Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).