From: Mark Brown <broonie@sirena.org.uk>
To: Jeff Garzik <jeff@garzik.org>
Cc: akpm@osdl.org, netdev@vger.kernel.org, jgarzik@pobox.com,
thockin@hockin.org
Subject: Re: [patch 3/9] natsemi: Add support for using MII port with no PHY
Date: Fri, 28 Apr 2006 14:01:39 +0100 [thread overview]
Message-ID: <20060428130139.GA20068@sirena.org.uk> (raw)
In-Reply-To: <445094F2.1060807@garzik.org>
On Thu, Apr 27, 2006 at 05:54:58AM -0400, Jeff Garzik wrote:
> >Provide a module option which configures the natsemi driver to use the
> >external MII port on the chip but ignore any PHYs that may be attached to
> >it. The link state will be left as it was when the driver started and can
> The proper way to do this is via the force_media boolean flag found in
> several net drivers.
I've had a look at several of the net drivers that implement this option
(e100, smc91x, starfire and the shared code in mii.c). Unless I'm
misreading the code it looks like the effect of this option in those
drivers is to disable autonegotiation but still configure the PHY when
the NIC is configured.
That is a subset of what the patch does and isn't sufficient for the
hardware this patch targets: sometimes there may be a PHY visible on the
MII bus but with a different configuration to the natsemi or there may
be no PHY present at all. In this case the code in the natsemi driver
that configures the PHY to match the configuration of the natsemi also
needs to be disabled.
It looks like I should implement a force_media option and redo this
patch to use that.
--
"You grabbed my hand and we fell into it, like a daydream - or a fever."
next prev parent reply other threads:[~2006-04-28 13:24 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-04-27 9:30 [patch 3/9] natsemi: Add support for using MII port with no PHY akpm
2006-04-27 9:54 ` Jeff Garzik
2006-04-28 13:01 ` Mark Brown [this message]
2006-05-03 11:07 ` Jeff Garzik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060428130139.GA20068@sirena.org.uk \
--to=broonie@sirena.org.uk \
--cc=akpm@osdl.org \
--cc=jeff@garzik.org \
--cc=jgarzik@pobox.com \
--cc=netdev@vger.kernel.org \
--cc=thockin@hockin.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).