Re: [PATCH 3/32] rt2x00: use pci_*_consistent for DMA mapping

[Michael Buesch <mb@bu3sch.de>]

[-- Attachment #1: Type: text/plain, Size: 1160 bytes --]

On Friday 28 April 2006 15:24, you wrote:
> struct data_ring{
> 	/*
> 	 * net_device where this ring belongs to.
> 	 */
> 	struct net_device			*net_dev;
> 
> 	/*
> 	 * Work structure for bottom half interrupt handling.
> 	 */
> 	struct work_struct			irq_work;
> 
> 	/*
> 	 * Base address for the device specific data entries.
> 	 */
> 	void					*entry;
> 
> 	/*
> 	 * TX queue statistic info.
> 	 */
> 	struct ieee80211_tx_queue_stats_data	stats;
> 
> 	/*
> 	 * TX Queue parameters.
> 	 */
> 	struct ieee80211_tx_queue_params	tx_params;
> 
> 	/*
> 	 * Base address for data ring.
> 	 */
> 	dma_addr_t				data_dma;
> 	void					*data_addr;
> 
> 	/*
> 	 * Index variables.
> 	 */
> 	u8					index;
> 	u8					index_done;
> 
> 	/*
> 	 * Size of device specific data entry structure.
> 	 */
> 	u16					entry_size;
> 
> 	/*
> 	 * Size of packet and descriptor in bytes.
> 	 */
> 	u16					data_size;
> 	u16					desc_size;
> } __attribute__ ((packed));

Why is this packed? I don't believe you write such a data
structure (which contains dscape specific structs) to some
device registers.

-- 
Greetings Michael.

[-- Attachment #2: Type: application/pgp-signature, Size: 191 bytes --]