From mboxrd@z Thu Jan 1 00:00:00 1970 From: Michael Buesch Subject: Re: [PATCH 3/32] rt2x00: use pci_*_consistent for DMA mapping Date: Fri, 28 Apr 2006 15:33:57 +0200 Message-ID: <200604281533.57372.mb@bu3sch.de> References: <200604280002.52839.IvDoorn@gmail.com> <20060428131533.GB3288@infradead.org> <200604281524.11670.IvDoorn@gmail.com> Mime-Version: 1.0 Content-Type: multipart/signed; boundary="nextPart1677747.h3PctgAC7T"; protocol="application/pgp-signature"; micalg=pgp-sha1 Content-Transfer-Encoding: 7bit Cc: Christoph Hellwig , netdev@vger.kernel.org, rt2x00-devel@lfcorreia.dyndns.org Return-path: Received: from static-ip-62-75-166-246.inaddr.intergenia.de ([62.75.166.246]:1173 "EHLO bu3sch.de") by vger.kernel.org with ESMTP id S1030383AbWD1N2g (ORCPT ); Fri, 28 Apr 2006 09:28:36 -0400 To: Ivo van Doorn In-Reply-To: <200604281524.11670.IvDoorn@gmail.com> Sender: netdev-owner@vger.kernel.org List-Id: netdev.vger.kernel.org --nextPart1677747.h3PctgAC7T Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Content-Disposition: inline On Friday 28 April 2006 15:24, you wrote: > struct data_ring{ > /* > * net_device where this ring belongs to. > */ > struct net_device *net_dev; >=20 > /* > * Work structure for bottom half interrupt handling. > */ > struct work_struct irq_work; >=20 > /* > * Base address for the device specific data entries. > */ > void *entry; >=20 > /* > * TX queue statistic info. > */ > struct ieee80211_tx_queue_stats_data stats; >=20 > /* > * TX Queue parameters. > */ > struct ieee80211_tx_queue_params tx_params; >=20 > /* > * Base address for data ring. > */ > dma_addr_t data_dma; > void *data_addr; >=20 > /* > * Index variables. > */ > u8 index; > u8 index_done; >=20 > /* > * Size of device specific data entry structure. > */ > u16 entry_size; >=20 > /* > * Size of packet and descriptor in bytes. > */ > u16 data_size; > u16 desc_size; > } __attribute__ ((packed)); Why is this packed? I don't believe you write such a data structure (which contains dscape specific structs) to some device registers. =2D-=20 Greetings Michael. --nextPart1677747.h3PctgAC7T Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.2.2 (GNU/Linux) iD8DBQBEUhnFlb09HEdWDKgRAmXWAKCCDuFLhF9+z+2ezPV+4P0f+MhvBwCguRdb V0HB+LU562TfUr3N0tH1HSA= =uiZ0 -----END PGP SIGNATURE----- --nextPart1677747.h3PctgAC7T--