From: "David Gómez" <david@pleyades.net>
To: Pekka J Enberg <penberg@cs.Helsinki.FI>
Cc: David Vrabel <dvrabel@cantab.net>,
Francois Romieu <romieu@fr.zoreil.com>,
Linux-kernel <linux-kernel@vger.kernel.org>,
netdev@vger.kernel.org
Subject: Re: IP1000 gigabit nic driver
Date: Fri, 28 Apr 2006 23:58:24 +0200 [thread overview]
Message-ID: <20060428215824.GA2922@fargo> (raw)
In-Reply-To: <Pine.LNX.4.58.0604281458110.19801@sbz-30.cs.Helsinki.FI>
Hi Pekka,
On Apr 28 at 02:59:01, Pekka J Enberg wrote:
> Here are some suggestions for coding style cleanups:
Couple of questions,
> - Use dev_{dbg,err,info,warn} for logging
Cannot, i need a "struct device" and most of the
there's only access to a "struct net_device". Am i
missing something?
> - Use proper naming convention for things like Length and pPHYParam
What's the convention for these names?
Thanks,
--
David Gómez Jabber ID: davidge@jabber.org
next prev parent reply other threads:[~2006-04-28 21:58 UTC|newest]
Thread overview: 53+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20060427142939.GA31473@fargo>
2006-04-27 18:56 ` IP1000 gigabit nic driver Francois Romieu
2006-04-27 22:26 ` David Vrabel
2006-04-28 7:57 ` David Gómez
2006-04-28 10:58 ` Pekka Enberg
2006-04-28 11:37 ` David Gómez
2006-04-28 11:51 ` Pekka J Enberg
2006-04-28 11:59 ` Pekka J Enberg
2006-04-28 21:58 ` David Gómez [this message]
2006-04-29 10:29 ` Pekka Enberg
2006-04-29 10:35 ` Arjan van de Ven
2006-04-29 12:21 ` David Gómez
2006-04-29 20:35 ` Pekka Enberg
2006-04-30 9:26 ` Pekka Enberg
2006-04-30 23:40 ` David Vrabel
2006-05-01 9:31 ` Pekka Enberg
2006-05-03 12:43 ` Andrew Morton
2006-05-03 13:06 ` Pekka J Enberg
2006-05-03 14:15 ` David Vrabel
2006-05-01 9:43 ` Pekka Enberg
2006-05-01 11:32 ` David Vrabel
2006-05-01 18:08 ` Pekka Enberg
2006-05-01 23:10 ` [PATCH 1/3] ipg: removal of unreachable code Francois Romieu
2006-05-02 6:36 ` Pekka J Enberg
2006-05-01 23:10 ` [PATCH 2/3] ipg: leaks in ipg_probe Francois Romieu
2006-05-02 6:41 ` Pekka J Enberg
2006-05-02 18:33 ` Francois Romieu
2006-05-02 19:04 ` Pekka Enberg
2006-05-02 22:30 ` [PATCH] ipg: removing more dead code David Gómez
2006-05-03 13:12 ` Pekka J Enberg
2006-05-03 21:00 ` [PATCH 2/3] ipg: leaks in ipg_probe David Gómez
2006-05-01 23:12 ` [PATCH 3/3] ipg: plug leaks in the error path of ipg_nic_open Francois Romieu
2006-05-02 6:45 ` Pekka J Enberg
2006-05-02 21:44 ` [PATCH 1/2] ipg: sanitize the pci device table Francois Romieu
2006-05-02 21:45 ` [PATCH 2/2] ipg: redundancy with mii.h Francois Romieu
2006-05-02 21:55 ` Francois Romieu
2006-05-03 6:16 ` Pekka J Enberg
2006-05-03 23:35 ` Francois Romieu
2006-05-04 6:52 ` David Vrabel
2006-05-05 0:24 ` Francois Romieu
2006-05-04 13:44 ` Pekka Enberg
2006-05-04 23:55 ` Francois Romieu
2006-05-20 21:03 ` David Vrabel
2006-05-21 7:23 ` Pekka Enberg
2006-05-21 10:16 ` Francois Romieu
2006-05-22 3:22 ` jesse\(建興\)
2006-05-23 6:50 ` jesse\(建興\)
2006-05-01 20:38 ` IP1000 gigabit nic driver Francois Romieu
2006-05-01 20:41 ` Lennert Buytenhek
2006-05-02 0:36 ` David Vrabel
2006-05-01 19:39 ` David Gómez
2006-04-29 12:58 ` David Vrabel
2006-04-28 11:59 ` Ingo Oeser
2006-04-28 7:54 ` David Gómez
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060428215824.GA2922@fargo \
--to=david@pleyades.net \
--cc=dvrabel@cantab.net \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=penberg@cs.Helsinki.FI \
--cc=romieu@fr.zoreil.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).