From: "David S. Miller" <davem@davemloft.net>
To: mchan@broadcom.com
Cc: netdev@vger.kernel.org
Subject: tw32_f() in tg3_write_mem()
Date: Sat, 29 Apr 2006 19:22:02 -0700 (PDT) [thread overview]
Message-ID: <20060429.192202.74748695.davem@davemloft.net> (raw)
At least for the TG3PCI_MEM_WIN_DATA register, I don't know how safe
it is to use tw32_f() there. Reads from a location can have side
effects, so doing a forced readback after a write could be dangerous.
And it isn't needed, as the tw32_f() done as we set the
TG3PCI_MEM_WIN_BASE_ADDR back to zero will flush all posted
writes.
Agreed?
next reply other threads:[~2006-04-30 2:24 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-04-30 2:22 David S. Miller [this message]
-- strict thread matches above, loose matches on Subject: below --
2006-05-01 5:05 tw32_f() in tg3_write_mem() Michael Chan
2006-05-01 6:07 ` David S. Miller
2006-05-01 14:53 ` Michael Chan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060429.192202.74748695.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=mchan@broadcom.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).