[AX25, ROSE] Remove useless SET_MODULE_OWNER calls.

[AX25, ROSE] Remove useless SET_MODULE_OWNER calls.

[Ralf Baechle DL5RB]

Signed-off-by: Ralf Baechle <ralf@linux-mips.org>

--

 net/netrom/nr_dev.c |    1 -
 net/rose/rose_dev.c |    1 -
 2 files changed, 2 deletions(-)

Index: linux-net.git/net/netrom/nr_dev.c
===================================================================
--- linux-net.git.orig/net/netrom/nr_dev.c	2006-04-29 01:43:47.000000000 +0100
+++ linux-net.git/net/netrom/nr_dev.c	2006-04-29 11:38:00.000000000 +0100
@@ -185,7 +185,6 @@ static struct net_device_stats *nr_get_s
 
 void nr_setup(struct net_device *dev)
 {
-	SET_MODULE_OWNER(dev);
 	dev->mtu		= NR_MAX_PACKET_SIZE;
 	dev->hard_start_xmit	= nr_xmit;
 	dev->open		= nr_open;
Index: linux-net.git/net/rose/rose_dev.c
===================================================================
--- linux-net.git.orig/net/rose/rose_dev.c	2006-04-29 01:43:47.000000000 +0100
+++ linux-net.git/net/rose/rose_dev.c	2006-04-29 11:38:00.000000000 +0100
@@ -135,7 +135,6 @@ static struct net_device_stats *rose_get
 
 void rose_setup(struct net_device *dev)
 {
-	SET_MODULE_OWNER(dev);
 	dev->mtu		= ROSE_MAX_PACKET_SIZE - 2;
 	dev->hard_start_xmit	= rose_xmit;
 	dev->open		= rose_open;

Re: [AX25, ROSE] Remove useless SET_MODULE_OWNER calls.

[Dan Williams]

On Sat, 2006-04-29 at 15:29 +0100, Ralf Baechle DL5RB wrote:
> Signed-off-by: Ralf Baechle <ralf@linux-mips.org>
> 
> --
> 
>  net/netrom/nr_dev.c |    1 -
>  net/rose/rose_dev.c |    1 -
>  2 files changed, 2 deletions(-)
> 
> Index: linux-net.git/net/netrom/nr_dev.c
> ===================================================================
> --- linux-net.git.orig/net/netrom/nr_dev.c	2006-04-29 01:43:47.000000000 +0100
> +++ linux-net.git/net/netrom/nr_dev.c	2006-04-29 11:38:00.000000000 +0100
> @@ -185,7 +185,6 @@ static struct net_device_stats *nr_get_s
>  
>  void nr_setup(struct net_device *dev)
>  {
> -	SET_MODULE_OWNER(dev);
>  	dev->mtu		= NR_MAX_PACKET_SIZE;
>  	dev->hard_start_xmit	= nr_xmit;
>  	dev->open		= nr_open;

Are these done by anything else now?  Did something change to make
SET_MODULE_OWNER useless in individual drivers?  I'm asking because I
was fairly sure that SET_MODULE_OWNER set up some sysfs links and such
that HAL depends on to figure out information about the driver and
hardware device, much like SET_NETDEV_DEV.

Dan

Re: [AX25, ROSE] Remove useless SET_MODULE_OWNER calls.

[Herbert Xu]

Dan Williams <dcbw@redhat.com> wrote:
> 
> Are these done by anything else now?  Did something change to make
> SET_MODULE_OWNER useless in individual drivers?  I'm asking because I

SET_MODULE_OWNER has been a no-op ever since Dave made live network
device driver modules unloadable nearly three years ago.

> was fairly sure that SET_MODULE_OWNER set up some sysfs links and such
> that HAL depends on to figure out information about the driver and
> hardware device, much like SET_NETDEV_DEV.

For PCI drivers the module information is injected by pci_register_driver.

Cheers,
-- 
Visit Openswan at http://www.openswan.org/
Email: Herbert Xu ~{PmV>HI~} <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

Re: [AX25, ROSE] Remove useless SET_MODULE_OWNER calls.

[Dan Williams]

On Sun, 2006-04-30 at 23:38 +1000, Herbert Xu wrote:
> Dan Williams <dcbw@redhat.com> wrote:
> > 
> > Are these done by anything else now?  Did something change to make
> > SET_MODULE_OWNER useless in individual drivers?  I'm asking because I
> 
> SET_MODULE_OWNER has been a no-op ever since Dave made live network
> device driver modules unloadable nearly three years ago.

Ah, thanks for the clarification.

dan

Re: [AX25, ROSE] Remove useless SET_MODULE_OWNER calls.

[David S. Miller]

From: Ralf Baechle DL5RB <ralf@linux-mips.org>
Date: Sat, 29 Apr 2006 15:29:43 +0100

> Signed-off-by: Ralf Baechle <ralf@linux-mips.org>

Applied, thanks.