From: Ivo van Doorn <ivdoorn@gmail.com>
To: "Randy.Dunlap" <rdunlap@xenotime.net>
Cc: netdev <netdev@vger.kernel.org>, jgarzik <jgarzik@pobox.com>
Subject: Re: [PATCH] irda-usb: use NULL instead of 0
Date: Tue, 2 May 2006 00:19:20 +0200 [thread overview]
Message-ID: <200605020019.25382.IvDoorn@gmail.com> (raw)
In-Reply-To: <20060501150807.b05fe450.rdunlap@xenotime.net>
[-- Attachment #1: Type: text/plain, Size: 1089 bytes --]
On Tuesday 2 May 2006 00:08, Randy.Dunlap wrote:
> From: Randy Dunlap <rdunlap@xenotime.net>
>
> Use NULL instead of 0 for a null pointer value (sparse warning):
> drivers/net/irda/irda-usb.c:1781:30: warning: Using plain integer as NULL pointer
>
> Signed-off-by: Randy Dunlap <rdunlap@xenotime.net>
> ---
> drivers/net/irda/irda-usb.c | 2 +-
> 1 files changed, 1 insertion(+), 1 deletion(-)
>
> --- linux-2617-rc3.orig/drivers/net/irda/irda-usb.c
> +++ linux-2617-rc3/drivers/net/irda/irda-usb.c
> @@ -1778,7 +1778,7 @@ static int irda_usb_probe(struct usb_int
>
> if (self->needspatch) {
> ret = usb_control_msg (self->usbdev, usb_sndctrlpipe (self->usbdev, 0),
> - 0x02, 0x40, 0, 0, 0, 0, msecs_to_jiffies(500));
> + 0x02, 0x40, 0, 0, NULL, 0, msecs_to_jiffies(500));
I could be mistaken, but wasn't the usb_control_msg timeout type changed in kernel 2.6.12?
The timeout value is no longer in jiffies but in msecs.
> if (ret < 0) {
> IRDA_DEBUG (0, "usb_control_msg failed %d\n", ret);
> goto err_out_3;
IvD
[-- Attachment #2: Type: application/pgp-signature, Size: 189 bytes --]
next prev parent reply other threads:[~2006-05-01 22:18 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-05-01 22:08 [PATCH] irda-usb: use NULL instead of 0 Randy.Dunlap
2006-05-01 22:19 ` Ivo van Doorn [this message]
2006-05-01 22:31 ` Randy.Dunlap
2006-05-07 1:34 ` David S. Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200605020019.25382.IvDoorn@gmail.com \
--to=ivdoorn@gmail.com \
--cc=jgarzik@pobox.com \
--cc=netdev@vger.kernel.org \
--cc=rdunlap@xenotime.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).