* [PATCH] irda-usb: use NULL instead of 0
@ 2006-05-01 22:08 Randy.Dunlap
2006-05-01 22:19 ` Ivo van Doorn
0 siblings, 1 reply; 4+ messages in thread
From: Randy.Dunlap @ 2006-05-01 22:08 UTC (permalink / raw)
To: netdev; +Cc: jgarzik
From: Randy Dunlap <rdunlap@xenotime.net>
Use NULL instead of 0 for a null pointer value (sparse warning):
drivers/net/irda/irda-usb.c:1781:30: warning: Using plain integer as NULL pointer
Signed-off-by: Randy Dunlap <rdunlap@xenotime.net>
---
drivers/net/irda/irda-usb.c | 2 +-
1 files changed, 1 insertion(+), 1 deletion(-)
--- linux-2617-rc3.orig/drivers/net/irda/irda-usb.c
+++ linux-2617-rc3/drivers/net/irda/irda-usb.c
@@ -1778,7 +1778,7 @@ static int irda_usb_probe(struct usb_int
if (self->needspatch) {
ret = usb_control_msg (self->usbdev, usb_sndctrlpipe (self->usbdev, 0),
- 0x02, 0x40, 0, 0, 0, 0, msecs_to_jiffies(500));
+ 0x02, 0x40, 0, 0, NULL, 0, msecs_to_jiffies(500));
if (ret < 0) {
IRDA_DEBUG (0, "usb_control_msg failed %d\n", ret);
goto err_out_3;
---
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] irda-usb: use NULL instead of 0
2006-05-01 22:08 [PATCH] irda-usb: use NULL instead of 0 Randy.Dunlap
@ 2006-05-01 22:19 ` Ivo van Doorn
2006-05-01 22:31 ` Randy.Dunlap
0 siblings, 1 reply; 4+ messages in thread
From: Ivo van Doorn @ 2006-05-01 22:19 UTC (permalink / raw)
To: Randy.Dunlap; +Cc: netdev, jgarzik
[-- Attachment #1: Type: text/plain, Size: 1089 bytes --]
On Tuesday 2 May 2006 00:08, Randy.Dunlap wrote:
> From: Randy Dunlap <rdunlap@xenotime.net>
>
> Use NULL instead of 0 for a null pointer value (sparse warning):
> drivers/net/irda/irda-usb.c:1781:30: warning: Using plain integer as NULL pointer
>
> Signed-off-by: Randy Dunlap <rdunlap@xenotime.net>
> ---
> drivers/net/irda/irda-usb.c | 2 +-
> 1 files changed, 1 insertion(+), 1 deletion(-)
>
> --- linux-2617-rc3.orig/drivers/net/irda/irda-usb.c
> +++ linux-2617-rc3/drivers/net/irda/irda-usb.c
> @@ -1778,7 +1778,7 @@ static int irda_usb_probe(struct usb_int
>
> if (self->needspatch) {
> ret = usb_control_msg (self->usbdev, usb_sndctrlpipe (self->usbdev, 0),
> - 0x02, 0x40, 0, 0, 0, 0, msecs_to_jiffies(500));
> + 0x02, 0x40, 0, 0, NULL, 0, msecs_to_jiffies(500));
I could be mistaken, but wasn't the usb_control_msg timeout type changed in kernel 2.6.12?
The timeout value is no longer in jiffies but in msecs.
> if (ret < 0) {
> IRDA_DEBUG (0, "usb_control_msg failed %d\n", ret);
> goto err_out_3;
IvD
[-- Attachment #2: Type: application/pgp-signature, Size: 189 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] irda-usb: use NULL instead of 0
2006-05-01 22:19 ` Ivo van Doorn
@ 2006-05-01 22:31 ` Randy.Dunlap
2006-05-07 1:34 ` David S. Miller
0 siblings, 1 reply; 4+ messages in thread
From: Randy.Dunlap @ 2006-05-01 22:31 UTC (permalink / raw)
To: Ivo van Doorn; +Cc: netdev, jgarzik
> I could be mistaken, but wasn't the usb_control_msg timeout type changed in kernel 2.6.12?
> The timeout value is no longer in jiffies but in msecs.
ugh, correct. Here's a new patch.
Thanks.
---
From: Randy Dunlap <rdunlap@xenotime.net>
Use NULL instead of 0 for a null pointer value (sparse warning):
drivers/net/irda/irda-usb.c:1781:30: warning: Using plain integer as NULL pointer
Correct timeout argument to use milliseconds instead of jiffies.
Signed-off-by: Randy Dunlap <rdunlap@xenotime.net>
---
drivers/net/irda/irda-usb.c | 2 +-
1 files changed, 1 insertion(+), 1 deletion(-)
--- linux-2617-rc3.orig/drivers/net/irda/irda-usb.c
+++ linux-2617-rc3/drivers/net/irda/irda-usb.c
@@ -1778,7 +1778,7 @@ static int irda_usb_probe(struct usb_int
if (self->needspatch) {
ret = usb_control_msg (self->usbdev, usb_sndctrlpipe (self->usbdev, 0),
- 0x02, 0x40, 0, 0, 0, 0, msecs_to_jiffies(500));
+ 0x02, 0x40, 0, 0, NULL, 0, 500);
if (ret < 0) {
IRDA_DEBUG (0, "usb_control_msg failed %d\n", ret);
goto err_out_3;
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] irda-usb: use NULL instead of 0
2006-05-01 22:31 ` Randy.Dunlap
@ 2006-05-07 1:34 ` David S. Miller
0 siblings, 0 replies; 4+ messages in thread
From: David S. Miller @ 2006-05-07 1:34 UTC (permalink / raw)
To: rdunlap; +Cc: ivdoorn, netdev, jgarzik
From: "Randy.Dunlap" <rdunlap@xenotime.net>
Date: Mon, 1 May 2006 15:31:34 -0700
> Use NULL instead of 0 for a null pointer value (sparse warning):
> drivers/net/irda/irda-usb.c:1781:30: warning: Using plain integer as NULL pointer
>
> Correct timeout argument to use milliseconds instead of jiffies.
>
> Signed-off-by: Randy Dunlap <rdunlap@xenotime.net>
Applied, thanks Randy.
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2006-05-07 1:34 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2006-05-01 22:08 [PATCH] irda-usb: use NULL instead of 0 Randy.Dunlap
2006-05-01 22:19 ` Ivo van Doorn
2006-05-01 22:31 ` Randy.Dunlap
2006-05-07 1:34 ` David S. Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).