From: "David S. Miller" <davem@davemloft.net>
To: imcdnzl@gmail.com
Cc: greearb@candelatech.com, herbert@gondor.apana.org.au,
davej@redhat.com, netdev@vger.kernel.org, stable@vger.kernel.org,
fedora-list@list.zikzak.de, fedoralist@kotoulas.de
Subject: Re: latest -stable breaks Squid
Date: Thu, 04 May 2006 16:25:46 -0700 (PDT) [thread overview]
Message-ID: <20060504.162546.88959729.davem@davemloft.net> (raw)
In-Reply-To: <cbec11ac0605031859n5ef0babcib5f970da1ced7df7@mail.gmail.com>
From: "Ian McDonald" <imcdnzl@gmail.com>
Date: Thu, 4 May 2006 13:59:04 +1200
> Wouldn't it be more likely commit 5d0b6f2bdaf7e016e750cd24164a241512d968a3
>
> as this touches net/ipv4/tcp_output.c and is also in same general area?
This commit makes us account transmit memory properly. Previously we
were underaccounting which is a serious error and in fact could result
in assertion failures due to sk->sk_forward_alloc going negative if
things were just right.
If this change is what makes an application go slower, then the
problem is likely that the socket send buffer limits are not being set
large enough.
That being said, the first thing that should be tried is reverting
the above mentioned change and see if the problem goes away. If
so, then we need to investigate what the bandwidth delay product is
for the connection, and whether the socket send buffer is set large
enough for that size of pipe.
next prev parent reply other threads:[~2006-05-04 23:26 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-05-03 21:19 latest -stable breaks Squid Dave Jones
2006-05-04 0:43 ` Dave Jones
2006-05-04 1:10 ` Herbert Xu
2006-05-04 1:22 ` Ben Greear
2006-05-04 1:59 ` Ian McDonald
2006-05-04 23:25 ` David S. Miller [this message]
2006-05-04 23:30 ` Herbert Xu
2006-05-04 23:47 ` Dave Jones
2006-05-05 8:49 ` [x86_64, NET] smp_rmb() in dst_destroy() seems very expensive, ditto in kfree_skb() Eric Dumazet
2006-05-05 10:06 ` Herbert Xu
2006-05-05 16:13 ` Very long list of struct dst_entry in dst_garbage_list Eric Dumazet
2006-05-05 17:05 ` [x86_64, NET] smp_rmb() in dst_destroy() seems very expensive, ditto in kfree_skb() Andi Kleen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060504.162546.88959729.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=davej@redhat.com \
--cc=fedora-list@list.zikzak.de \
--cc=fedoralist@kotoulas.de \
--cc=greearb@candelatech.com \
--cc=herbert@gondor.apana.org.au \
--cc=imcdnzl@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).