* sky2 1.3-rc1 [not found] <1146667951.3056.25.camel@fc5test.deadmoose.com> @ 2006-05-03 19:05 ` Stephen Hemminger 2006-05-05 14:34 ` Daniel Drake 0 siblings, 1 reply; 6+ messages in thread From: Stephen Hemminger @ 2006-05-03 19:05 UTC (permalink / raw) To: Bill Hoover, Thomas Glanzmann, Bertrand Jacquin, micheleschi, Daniel Drake Cc: netdev Here is a new version that addresses some of the outstanding bugs. * There was a race in receive processing that would cause hang * Some more support for Yukon Ultra found in dual-core Centrino laptops (I want one of these). It does not fix the problems with dual port cards corrupting receive data (and possibly memory). http://developer.osdl.org/shemminger/prototypes/sky2-1.3-rc1.tar.bz2 If this works for most people, I'll post as separate patches for 2.6.17 tomorrow. ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: sky2 1.3-rc1 2006-05-03 19:05 ` sky2 1.3-rc1 Stephen Hemminger @ 2006-05-05 14:34 ` Daniel Drake 2006-05-05 17:35 ` Thomas Glanzmann 0 siblings, 1 reply; 6+ messages in thread From: Daniel Drake @ 2006-05-05 14:34 UTC (permalink / raw) To: Stephen Hemminger Cc: Bill Hoover, Thomas Glanzmann, Bertrand Jacquin, micheleschi, netdev, teppic74 Stephen Hemminger wrote: > Here is a new version that addresses some of the outstanding bugs. > * There was a race in receive processing that would cause hang > * Some more support for Yukon Ultra found in dual-core Centrino > laptops (I want one of these). > > It does not fix the problems with dual port cards corrupting receive > data (and possibly memory). > > http://developer.osdl.org/shemminger/prototypes/sky2-1.3-rc1.tar.bz2 > > If this works for most people, I'll post as separate patches for 2.6.17 > tomorrow. > Barry Shilliday at http://bugs.gentoo.org/132056 reports that 1.3-rc1 solves his earlier problems introduced in v1.1 are solved. However, it's not perfect, as latencies are much higher than they used to be. v0.15: 64 bytes from 10.0.0.138: icmp_seq=2 ttl=64 time=0.467 ms v1.3-rc1: 64 bytes from 10.0.0.138: icmp_seq=4 ttl=64 time=32.9 ms Daniel ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: sky2 1.3-rc1 2006-05-05 14:34 ` Daniel Drake @ 2006-05-05 17:35 ` Thomas Glanzmann 2006-05-05 17:45 ` Stephen Hemminger 0 siblings, 1 reply; 6+ messages in thread From: Thomas Glanzmann @ 2006-05-05 17:35 UTC (permalink / raw) To: Daniel Drake Cc: Stephen Hemminger, Bill Hoover, Bertrand Jacquin, micheleschi, netdev, teppic74 Hello, > > http://developer.osdl.org/shemminger/prototypes/sky2-1.3-rc1.tar.bz2 > v0.15: > 64 bytes from 10.0.0.138: icmp_seq=2 ttl=64 time=0.467 ms > v1.3-rc1: > 64 bytes from 10.0.0.138: icmp_seq=4 ttl=64 time=32.9 ms I can't confirm this. For me it is just perfect: 64 bytes from 89.106.66.1: icmp_seq=1 ttl=64 time=0.278 ms 0000:04:00.0 Ethernet controller: Marvell Technology Group Ltd.: Unknown device 4361 (rev 17) Thomas ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: sky2 1.3-rc1 2006-05-05 17:35 ` Thomas Glanzmann @ 2006-05-05 17:45 ` Stephen Hemminger 2006-05-05 18:42 ` Daniel Drake 0 siblings, 1 reply; 6+ messages in thread From: Stephen Hemminger @ 2006-05-05 17:45 UTC (permalink / raw) To: Thomas Glanzmann Cc: Daniel Drake, Bill Hoover, Bertrand Jacquin, micheleschi, netdev, teppic74 On Fri, 5 May 2006 19:35:09 +0200 Thomas Glanzmann <sithglan@stud.uni-erlangen.de> wrote: > Hello, > > > > http://developer.osdl.org/shemminger/prototypes/sky2-1.3-rc1.tar.bz2 > > > v0.15: > > 64 bytes from 10.0.0.138: icmp_seq=2 ttl=64 time=0.467 ms > > > v1.3-rc1: > > 64 bytes from 10.0.0.138: icmp_seq=4 ttl=64 time=32.9 ms > > I can't confirm this. For me it is just perfect: > > 64 bytes from 89.106.66.1: icmp_seq=1 ttl=64 time=0.278 ms > > 0000:04:00.0 Ethernet controller: Marvell Technology Group Ltd.: Unknown device 4361 (rev 17) > > Thomas What is happening is that if there is a misconfiguration and irq routing is messed up (ie edge trigged). The driver will degenerate to polling every 100ms. If your system is this misconfigured, then ACPI or the BIOS needs to be fixed and the driver really only needs to work well enough to get the bug report out ;-) The older driver was doing rewhacking the Transmit IRQ status timer, so it would give a bogus transmit status interrupt and that was masking issues. ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: sky2 1.3-rc1 2006-05-05 17:45 ` Stephen Hemminger @ 2006-05-05 18:42 ` Daniel Drake 2006-05-05 19:43 ` Stephen Hemminger 0 siblings, 1 reply; 6+ messages in thread From: Daniel Drake @ 2006-05-05 18:42 UTC (permalink / raw) To: Stephen Hemminger Cc: Thomas Glanzmann, Bill Hoover, Bertrand Jacquin, micheleschi, netdev, teppic74 Stephen Hemminger wrote: > What is happening is that if there is a misconfiguration and irq routing > is messed up (ie edge trigged). The driver will degenerate to polling every 100ms. > If your system is this misconfigured, then ACPI or the BIOS needs to be fixed > and the driver really only needs to work well enough to get the bug report out ;-) Ok, thanks for the explanation. Can you give any hints as to how we can classify this misconfiguration? Barry's system has a level triggered IRQ assigned to sky2, and that IRQ is not shared: http://bugs.gentoo.org/show_bug.cgi?id=132056#c3 I'm just looking for something I can take to the ACPI developers, other than "its broken because Stephen said so" ;) Thanks. Daniel ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: sky2 1.3-rc1 2006-05-05 18:42 ` Daniel Drake @ 2006-05-05 19:43 ` Stephen Hemminger 0 siblings, 0 replies; 6+ messages in thread From: Stephen Hemminger @ 2006-05-05 19:43 UTC (permalink / raw) To: Daniel Drake Cc: Thomas Glanzmann, Bill Hoover, Bertrand Jacquin, micheleschi, netdev, teppic74 On Fri, 05 May 2006 19:42:27 +0100 Daniel Drake <dsd@gentoo.org> wrote: > Stephen Hemminger wrote: > > What is happening is that if there is a misconfiguration and irq routing > > is messed up (ie edge trigged). The driver will degenerate to polling every 100ms. > > If your system is this misconfigured, then ACPI or the BIOS needs to be fixed > > and the driver really only needs to work well enough to get the bug report out ;-) > > Ok, thanks for the explanation. > > Can you give any hints as to how we can classify this misconfiguration? > Barry's system has a level triggered IRQ assigned to sky2, and that IRQ > is not shared: > > http://bugs.gentoo.org/show_bug.cgi?id=132056#c3 > > I'm just looking for something I can take to the ACPI developers, other > than "its broken because Stephen said so" ;) Try running idle_timeout=0 module parameter. In that case there will be no polling timer. If it just hangs, then the problem is missed interrupt. You could use this to see if you are getting irq's --- sky2.orig/drivers/net/sky2.c +++ sky2/drivers/net/sky2.c @@ -2125,6 +2125,9 @@ static int sky2_poll(struct net_device * int work_done = 0; u32 status = sky2_read32(hw, B0_Y2_SP_EISR); + if (netif_msg_intr((struct sky2_port *) netdev_priv(dev0))) + printk(KERN_DEBUG PFX "poll status %#x\n", status); + if (status & Y2_IS_HW_ERR) sky2_hw_intr(hw); @@ -2183,6 +2186,9 @@ static irqreturn_t sky2_intr(int irq, vo if (status == 0 || status == ~0) return IRQ_NONE; + if (netif_msg_intr((struct sky2_port *) netdev_priv(dev0))) + printk(KERN_DEBUG PFX "irq status %#x\n", status); + prefetch(&hw->st_le[hw->st_idx]); if (likely(__netif_rx_schedule_prep(dev0))) __netif_rx_schedule(dev0); ^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2006-05-05 19:43 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <1146667951.3056.25.camel@fc5test.deadmoose.com>
2006-05-03 19:05 ` sky2 1.3-rc1 Stephen Hemminger
2006-05-05 14:34 ` Daniel Drake
2006-05-05 17:35 ` Thomas Glanzmann
2006-05-05 17:45 ` Stephen Hemminger
2006-05-05 18:42 ` Daniel Drake
2006-05-05 19:43 ` Stephen Hemminger
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).