From: Michael Buesch <mb@bu3sch.de>
To: linville@tuxdriver.com
Cc: bcm43xx-dev@lists.berlios.de, Andrew Morton <akpm@osdl.org>,
netdev@vger.kernel.org, David Woodhouse <dwmw2@infradead.org>
Subject: Re: Machine check in bcm43xx_phy_initg
Date: Fri, 5 May 2006 19:42:39 +0200 [thread overview]
Message-ID: <200605051942.39552.mb@bu3sch.de> (raw)
In-Reply-To: <1146849577.2766.18.camel@pmac.infradead.org>
On Friday 05 May 2006 19:19, David Woodhouse wrote:
> On Fri, 2006-05-05 at 12:59 -0400, Joseph Jezak wrote:
> > I fixed the specs, it should be bcm->chip_package == 2, sorry for the
> > mistake.
>
> Thanks. The correct patch should look like this then...
>
> [BCM43xx] Fix access to non-existent PHY registers
>
> Fix the conditions under which we poke at the APHY registers in
> bcm43xx_phy_initg() to avoid a machine check on chips where they don't
> exist.
>
> Signed-off-by: David Woodhouse <dwmw2@infradead.org>
Signed-off-by: Michael Buesch <mb@bu3sch.de>
John, please apply. I will also send a patch for d80211.
> --- linux-2.6.16.ppc64/drivers/net/wireless/bcm43xx/bcm43xx_phy.c~ 2006-05-04 19:16:09.000000000 +0100
> +++ linux-2.6.16.ppc64/drivers/net/wireless/bcm43xx/bcm43xx_phy.c 2006-05-05 17:22:57.000000000 +0100
> @@ -1287,7 +1287,7 @@ static void bcm43xx_phy_initg(struct bcm
> if (radio->revision == 8)
> bcm43xx_phy_write(bcm, 0x0805, 0x3230);
> bcm43xx_phy_init_pctl(bcm);
> - if (bcm->chip_id == 0x4306 && bcm->chip_package != 2) {
> + if (bcm->chip_id == 0x4306 && bcm->chip_package == 2) {
> bcm43xx_phy_write(bcm, 0x0429,
> bcm43xx_phy_read(bcm, 0x0429) & 0xBFFF);
> bcm43xx_phy_write(bcm, 0x04C3,
>
--
Greetings Michael.
next parent reply other threads:[~2006-05-05 17:36 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1146847015.2766.10.camel@pmac.infradead.org>
[not found] ` <445B8474.302@gentoo.org>
[not found] ` <1146849577.2766.18.camel@pmac.infradead.org>
2006-05-05 17:42 ` Michael Buesch [this message]
2006-05-05 18:18 ` Machine check in bcm43xx_phy_initg David Woodhouse
2006-05-05 18:27 ` Michael Buesch
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200605051942.39552.mb@bu3sch.de \
--to=mb@bu3sch.de \
--cc=akpm@osdl.org \
--cc=bcm43xx-dev@lists.berlios.de \
--cc=dwmw2@infradead.org \
--cc=linville@tuxdriver.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).