* Re: Machine check in bcm43xx_phy_initg
[not found] ` <1146849577.2766.18.camel@pmac.infradead.org>
@ 2006-05-05 17:42 ` Michael Buesch
2006-05-05 18:18 ` David Woodhouse
0 siblings, 1 reply; 3+ messages in thread
From: Michael Buesch @ 2006-05-05 17:42 UTC (permalink / raw)
To: linville; +Cc: bcm43xx-dev, Andrew Morton, netdev, David Woodhouse
On Friday 05 May 2006 19:19, David Woodhouse wrote:
> On Fri, 2006-05-05 at 12:59 -0400, Joseph Jezak wrote:
> > I fixed the specs, it should be bcm->chip_package == 2, sorry for the
> > mistake.
>
> Thanks. The correct patch should look like this then...
>
> [BCM43xx] Fix access to non-existent PHY registers
>
> Fix the conditions under which we poke at the APHY registers in
> bcm43xx_phy_initg() to avoid a machine check on chips where they don't
> exist.
>
> Signed-off-by: David Woodhouse <dwmw2@infradead.org>
Signed-off-by: Michael Buesch <mb@bu3sch.de>
John, please apply. I will also send a patch for d80211.
> --- linux-2.6.16.ppc64/drivers/net/wireless/bcm43xx/bcm43xx_phy.c~ 2006-05-04 19:16:09.000000000 +0100
> +++ linux-2.6.16.ppc64/drivers/net/wireless/bcm43xx/bcm43xx_phy.c 2006-05-05 17:22:57.000000000 +0100
> @@ -1287,7 +1287,7 @@ static void bcm43xx_phy_initg(struct bcm
> if (radio->revision == 8)
> bcm43xx_phy_write(bcm, 0x0805, 0x3230);
> bcm43xx_phy_init_pctl(bcm);
> - if (bcm->chip_id == 0x4306 && bcm->chip_package != 2) {
> + if (bcm->chip_id == 0x4306 && bcm->chip_package == 2) {
> bcm43xx_phy_write(bcm, 0x0429,
> bcm43xx_phy_read(bcm, 0x0429) & 0xBFFF);
> bcm43xx_phy_write(bcm, 0x04C3,
>
--
Greetings Michael.
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: Machine check in bcm43xx_phy_initg
2006-05-05 17:42 ` Machine check in bcm43xx_phy_initg Michael Buesch
@ 2006-05-05 18:18 ` David Woodhouse
2006-05-05 18:27 ` Michael Buesch
0 siblings, 1 reply; 3+ messages in thread
From: David Woodhouse @ 2006-05-05 18:18 UTC (permalink / raw)
To: Michael Buesch; +Cc: linville, bcm43xx-dev, Andrew Morton, netdev
On Fri, 2006-05-05 at 19:42 +0200, Michael Buesch wrote:
> > Signed-off-by: David Woodhouse <dwmw2@infradead.org>
> Signed-off-by: Michael Buesch <mb@bu3sch.de>
>
> John, please apply. I will also send a patch for d80211.
Would be good to get this into 2.6.17 too.
--
dwmw2
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: Machine check in bcm43xx_phy_initg
2006-05-05 18:18 ` David Woodhouse
@ 2006-05-05 18:27 ` Michael Buesch
0 siblings, 0 replies; 3+ messages in thread
From: Michael Buesch @ 2006-05-05 18:27 UTC (permalink / raw)
To: David Woodhouse; +Cc: linville, bcm43xx-dev, Andrew Morton, netdev
On Friday 05 May 2006 20:18, you wrote:
> On Fri, 2006-05-05 at 19:42 +0200, Michael Buesch wrote:
> > > Signed-off-by: David Woodhouse <dwmw2@infradead.org>
> > Signed-off-by: Michael Buesch <mb@bu3sch.de>
> >
> > John, please apply. I will also send a patch for d80211.
>
> Would be good to get this into 2.6.17 too.
Absolutely, as it crashes machines.
That was my intention. ;)
--
Greetings Michael.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2006-05-05 18:20 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <1146847015.2766.10.camel@pmac.infradead.org>
[not found] ` <445B8474.302@gentoo.org>
[not found] ` <1146849577.2766.18.camel@pmac.infradead.org>
2006-05-05 17:42 ` Machine check in bcm43xx_phy_initg Michael Buesch
2006-05-05 18:18 ` David Woodhouse
2006-05-05 18:27 ` Michael Buesch
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).