From: "David S. Miller" <davem@davemloft.net>
To: shemminger@osdl.org
Cc: netdev@vger.kernel.org
Subject: Re: [RFC] netdev sysfs failure handling
Date: Sat, 06 May 2006 18:06:22 -0700 (PDT) [thread overview]
Message-ID: <20060506.180622.117885702.davem@davemloft.net> (raw)
In-Reply-To: <20060421134205.2786a0ee@localhost.localdomain>
From: Stephen Hemminger <shemminger@osdl.org>
Date: Fri, 21 Apr 2006 13:42:05 -0700
> In case of sysfs failure, don't let device be brought up.
> It can be cleared by unregister_netdevice so module can be unloaded
> normally.
>
> Signed-off-by: Stephen Hemminger <shemminger@osdl.org>
I'm not so sure about this, a hot plug event could clear that bit too.
The problem I think is that here we've structured things such that we
can't handle the error properly and pass it back to the
register_netdevice() caller because we do the sysfs registry call in
the rtnl_unlock() todo list execution.
Next, even if you prevent the device from being brought up, people
can still assign IP addresses and do other stuff to the device so
it still sort of behaves as if it is there.
It would therefore be the best if we can do this stuff inside of
register_netdevice(), then handle and propagate any errors correctly.
next prev parent reply other threads:[~2006-05-07 1:06 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-04-21 20:42 [RFC] netdev sysfs failure handling Stephen Hemminger
2006-05-07 1:06 ` David S. Miller [this message]
2006-05-09 19:01 ` Stephen Hemminger
2006-05-09 21:05 ` David S. Miller
2006-05-09 21:40 ` Stephen Hemminger
2006-05-09 22:43 ` David S. Miller
2006-05-09 22:50 ` Stephen Hemminger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060506.180622.117885702.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
--cc=shemminger@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).