* Re: Associate on 'ifconfig up' [not found] <1146847107.2766.13.camel@pmac.infradead.org> @ 2006-05-06 18:24 ` David Woodhouse 2006-05-07 13:06 ` Michael Buesch 0 siblings, 1 reply; 3+ messages in thread From: David Woodhouse @ 2006-05-06 18:24 UTC (permalink / raw) To: bcm43xx-dev; +Cc: netdev, linville On Fri, 2006-05-05 at 17:38 +0100, David Woodhouse wrote: > I still need this hack to work around the fact that softmac doesn't > attempt to associate when we bring the device up... It'd be quite good to get this fixed in 2.6.17 too. Otherwise, the device doesn't manage to associate if you use the fairly common sequence of iwconfig then dhclient. It's a bit of an evil hack and it should really be fixed in softmac -- but it's only moving an _existing_ hack from one place in the driver to another. Signed-off-by: David Woodhouse <dwmw2@infradead.org> --- linux-2.6.16.ppc/drivers/net/wireless/bcm43xx/bcm43xx_main.c.orig 2006-05-05 17:14:26.000000000 +0100 +++ linux-2.6.16.ppc/drivers/net/wireless/bcm43xx/bcm43xx_main.c 2006-05-05 17:15:19.000000000 +0100 @@ -3263,6 +3263,9 @@ static int bcm43xx_init_board(struct bcm bcm43xx_sysfs_register(bcm); //FIXME: check for bcm43xx_sysfs_register failure. This function is a bit messy regarding unwinding, though... + /*FIXME: This should be handled by softmac instead. */ + schedule_work(&bcm->softmac->associnfo.work); + assert(err == 0); out: return err; @@ -3937,9 +3940,6 @@ static int bcm43xx_resume(struct pci_dev netif_device_attach(net_dev); - /*FIXME: This should be handled by softmac instead. */ - schedule_work(&bcm->softmac->associnfo.work); - dprintk(KERN_INFO PFX "Device resumed.\n"); return 0; -- dwmw2 ^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: Associate on 'ifconfig up' 2006-05-06 18:24 ` Associate on 'ifconfig up' David Woodhouse @ 2006-05-07 13:06 ` Michael Buesch 2006-05-09 18:53 ` David Woodhouse 0 siblings, 1 reply; 3+ messages in thread From: Michael Buesch @ 2006-05-07 13:06 UTC (permalink / raw) To: linville; +Cc: bcm43xx-dev, netdev, David Woodhouse On Saturday 06 May 2006 20:24, David Woodhouse wrote: > On Fri, 2006-05-05 at 17:38 +0100, David Woodhouse wrote: > > I still need this hack to work around the fact that softmac doesn't > > attempt to associate when we bring the device up... > > It'd be quite good to get this fixed in 2.6.17 too. Otherwise, the > device doesn't manage to associate if you use the fairly common sequence > of iwconfig then dhclient. > > It's a bit of an evil hack and it should really be fixed in softmac -- > but it's only moving an _existing_ hack from one place in the driver to > another. > > Signed-off-by: David Woodhouse <dwmw2@infradead.org> Signed-off-by: Michael Buesch <mb@bu3sch.de> John, please try to push this before 2.6.17. Thanks. > --- linux-2.6.16.ppc/drivers/net/wireless/bcm43xx/bcm43xx_main.c.orig 2006-05-05 17:14:26.000000000 +0100 > +++ linux-2.6.16.ppc/drivers/net/wireless/bcm43xx/bcm43xx_main.c 2006-05-05 17:15:19.000000000 +0100 > @@ -3263,6 +3263,9 @@ static int bcm43xx_init_board(struct bcm > bcm43xx_sysfs_register(bcm); > //FIXME: check for bcm43xx_sysfs_register failure. This function is a bit messy regarding unwinding, though... > > + /*FIXME: This should be handled by softmac instead. */ > + schedule_work(&bcm->softmac->associnfo.work); > + > assert(err == 0); > out: > return err; > @@ -3937,9 +3940,6 @@ static int bcm43xx_resume(struct pci_dev > > netif_device_attach(net_dev); > > - /*FIXME: This should be handled by softmac instead. */ > - schedule_work(&bcm->softmac->associnfo.work); > - > dprintk(KERN_INFO PFX "Device resumed.\n"); > > return 0; > -- Greetings Michael. ^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: Associate on 'ifconfig up' 2006-05-07 13:06 ` Michael Buesch @ 2006-05-09 18:53 ` David Woodhouse 0 siblings, 0 replies; 3+ messages in thread From: David Woodhouse @ 2006-05-09 18:53 UTC (permalink / raw) To: Michael Buesch; +Cc: linville, bcm43xx-dev, netdev, Stephen Hemminger On Sun, 2006-05-07 at 15:06 +0200, Michael Buesch wrote: > On Saturday 06 May 2006 20:24, David Woodhouse wrote: > > On Fri, 2006-05-05 at 17:38 +0100, David Woodhouse wrote: > > > I still need this hack to work around the fact that softmac doesn't > > > attempt to associate when we bring the device up... > > > > It'd be quite good to get this fixed in 2.6.17 too. Otherwise, the > > device doesn't manage to associate if you use the fairly common sequence > > of iwconfig then dhclient. > > > > It's a bit of an evil hack and it should really be fixed in softmac -- > > but it's only moving an _existing_ hack from one place in the driver to > > another. > > > > Signed-off-by: David Woodhouse <dwmw2@infradead.org> > > Signed-off-by: Michael Buesch <mb@bu3sch.de> > > John, please try to push this before 2.6.17. > Thanks. This didn't make it into the tree that Linus just pulled? -- dwmw2 ^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2006-05-09 18:53 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <1146847107.2766.13.camel@pmac.infradead.org>
2006-05-06 18:24 ` Associate on 'ifconfig up' David Woodhouse
2006-05-07 13:06 ` Michael Buesch
2006-05-09 18:53 ` David Woodhouse
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).