From: Stephen Hemminger <shemminger@osdl.org>
To: "David S. Miller" <davem@davemloft.net>
Cc: herbert@gondor.apana.org.au, patrakov@ums.usu.ru,
netdev@vger.kernel.org, akpm@osdl.org
Subject: Re: [PATCH] netdev: hotplug napi race cleanup
Date: Mon, 8 May 2006 12:02:24 -0700 [thread overview]
Message-ID: <20060508120224.63c84ad6@localhost.localdomain> (raw)
In-Reply-To: <20060508.113731.97080992.davem@davemloft.net>
On Mon, 08 May 2006 11:37:31 -0700 (PDT)
"David S. Miller" <davem@davemloft.net> wrote:
> From: Stephen Hemminger <shemminger@osdl.org>
> Date: Mon, 8 May 2006 09:54:58 -0700
>
> > The issue is are there network devices that can't sleep during
> > register_netdevice?
>
> Oh right, I forgot about that.
We could do something like this in register_netdevice()
if (in_atomic() || irqs_disabled())
net_set_todo(dev);
else {
dev->reg_state = NETREG_REGISTERED;
ret = netdev_register_sysfs(dev);
if (ret) {
...
}
It seems a bit grotty, and might cause pain later.
prev parent reply other threads:[~2006-05-08 19:02 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20060418042300.GA11061@kroah.com>
[not found] ` <20060418042345.GB11061@kroah.com>
[not found] ` <44448DFF.3080108@ums.usu.ru>
[not found] ` <20060418153951.GC30485@kroah.com>
[not found] ` <4445BB0F.6010305@ums.usu.ru>
2006-04-21 17:25 ` Hotplug race on name change Stephen Hemminger
2006-04-22 0:28 ` Herbert Xu
2006-04-24 22:23 ` [PATCH] netdev: hotplug napi race cleanup Stephen Hemminger
2006-04-25 1:30 ` Andrew Morton
2006-04-26 9:43 ` David S. Miller
2006-05-07 1:09 ` David S. Miller
2006-05-08 16:54 ` Stephen Hemminger
2006-05-08 18:37 ` David S. Miller
2006-05-08 19:02 ` Stephen Hemminger [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060508120224.63c84ad6@localhost.localdomain \
--to=shemminger@osdl.org \
--cc=akpm@osdl.org \
--cc=davem@davemloft.net \
--cc=herbert@gondor.apana.org.au \
--cc=netdev@vger.kernel.org \
--cc=patrakov@ums.usu.ru \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).