netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jean Tourrilhes <jt@hpl.hp.com>
To: Pavel Roskin <proski@gnu.org>
Cc: NetDev <netdev@vger.kernel.org>
Subject: Re: dBm cutoff at -1dBm is too low
Date: Mon, 8 May 2006 10:17:11 -0700	[thread overview]
Message-ID: <20060508171711.GA10948@bougret.hpl.hp.com> (raw)
In-Reply-To: <1146972732.24434.89.camel@dv>

On Sat, May 06, 2006 at 11:32:12PM -0400, Pavel Roskin wrote:
> On Fri, 2006-05-05 at 10:28 -0700, Jean Tourrilhes wrote:
> > 
> > 	There are still quite a few drivers which have not been
> > converted to use IW_QUAL_DBM, so I don't want to drop the backward
> > compatibility yet.
> 
> But shouldn't you trust the drivers using IW_QUAL_DBM, whether the value
> is positive or negative?

	You can't remove the test, making the rest pointeless. Old
style driver never used the flags, new style driver that don't report
dBm will never use the flags, and there is not way to dinstinguish
both, apart from the 'sign' of the value.
	We may want to perform an audit of the various drivers,
in-tree and out-of-tree, to see how much progress we have made so far.

> The problem is the driver has to take care of it.  It cannot just take
> the dBm value from the card and pass it to userspace.  It has to limit
> the value at -1.  Otherwise iwconfig would show -256dBm or something
> like that.  I can imagine that some GUI can decide that the connection
> has become very bad, and that would confuse the user.

	Correct.

> I suggest -192dBm to 63dBm.  That's enough padding on both sides, so
> that the drivers can just pass the firmware value without checking.

	Yep, seems reasonable.

> Pavel Roskin

	Jean

  reply	other threads:[~2006-05-08 17:17 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-05-04 16:37 dBm cutoff at -1dBm is too low Pavel Roskin
2006-05-05 17:28 ` Jean Tourrilhes
2006-05-07  3:32   ` Pavel Roskin
2006-05-08 17:17     ` Jean Tourrilhes [this message]
2006-05-09  4:54       ` Pavel Roskin
2006-05-09 18:54         ` Jean Tourrilhes
2006-05-08  3:35   ` Pavel Roskin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20060508171711.GA10948@bougret.hpl.hp.com \
    --to=jt@hpl.hp.com \
    --cc=netdev@vger.kernel.org \
    --cc=proski@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).