From: Stephen Hemminger <shemminger@osdl.org>
To: "David S. Miller" <davem@davemloft.net>
Cc: netdev@vger.kernel.org
Subject: Re: [RFC] netdev sysfs failure handling
Date: Tue, 9 May 2006 14:40:49 -0700 [thread overview]
Message-ID: <20060509144049.0924d41c@localhost.localdomain> (raw)
In-Reply-To: <20060509.140501.18000999.davem@davemloft.net>
On Tue, 09 May 2006 14:05:01 -0700 (PDT)
"David S. Miller" <davem@davemloft.net> wrote:
> From: Stephen Hemminger <shemminger@osdl.org>
> Date: Tue, 9 May 2006 12:01:07 -0700
>
> > Something like this would handle errors better, but introduce possible
> > problems for drivers that call register_netdevice with irq's disabled.
> > There was some comment about racing with linkwatch, but don't see how
> > that could happen during creation.
> >
> > For 2.6.18?
>
> I've been thinking about this a bit more.
>
> How can anyone be using this with IRQ's disabled if we have
> an ASSERT_RTNL() there?
Agreed, especially since rtnl is now a real mutex. The case, that
I was worried about:
rtnl_lock()
spin_lock_irq(&mylock);
x = register_netdevice();
...
Doesn't show up in any current code, even for the pseudo devices
and funny virtualized interfaces.
next prev parent reply other threads:[~2006-05-09 21:40 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-04-21 20:42 [RFC] netdev sysfs failure handling Stephen Hemminger
2006-05-07 1:06 ` David S. Miller
2006-05-09 19:01 ` Stephen Hemminger
2006-05-09 21:05 ` David S. Miller
2006-05-09 21:40 ` Stephen Hemminger [this message]
2006-05-09 22:43 ` David S. Miller
2006-05-09 22:50 ` Stephen Hemminger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060509144049.0924d41c@localhost.localdomain \
--to=shemminger@osdl.org \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).