From: Stephen Hemminger <shemminger@osdl.org>
To: ctindel@users.sourceforge.net, Jay Vosburgh <fubar@us.ibm.com>
Cc: bonding-devel@lists.sourceforge.net, netdev@vger.kernel.org
Subject: [PATCH] bonding: fix sparse warnings
Date: Wed, 10 May 2006 16:14:05 -0700 [thread overview]
Message-ID: <20060510161405.4ded4250@localhost.localdomain> (raw)
Fix warning from sparse in bonding code about "incorrect type in assignment"
Signed-off-by: Stephen Hemminger <shemminger@osdl.org>
--- orig/drivers/net/bonding/bond_main.c 2006-05-04 16:22:10.000000000 -0700
+++ new/drivers/net/bonding/bond_main.c 2006-05-10 16:04:38.000000000 -0700
@@ -629,7 +629,7 @@
ioctl = slave_dev->do_ioctl;
strncpy(ifr.ifr_name, slave_dev->name, IFNAMSIZ);
etool.cmd = ETHTOOL_GSET;
- ifr.ifr_data = (char*)&etool;
+ ifr.ifr_data = (void __user *) &etool;
if (!ioctl || (IOCTL(slave_dev, &ifr, SIOCETHTOOL) < 0)) {
return -1;
}
@@ -726,7 +726,7 @@
if (ioctl) {
strncpy(ifr.ifr_name, slave_dev->name, IFNAMSIZ);
etool.cmd = ETHTOOL_GLINK;
- ifr.ifr_data = (char*)&etool;
+ ifr.ifr_data = (void __user *) &etool;
if (IOCTL(slave_dev, &ifr, SIOCETHTOOL) == 0) {
if (etool.data == 1) {
return BMSR_LSTATUS;
next reply other threads:[~2006-05-10 23:14 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-05-10 23:14 Stephen Hemminger [this message]
2006-05-10 23:22 ` [PATCH] bonding: fix sparse warnings Al Viro
2006-05-11 3:45 ` Stephen Hemminger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060510161405.4ded4250@localhost.localdomain \
--to=shemminger@osdl.org \
--cc=bonding-devel@lists.sourceforge.net \
--cc=ctindel@users.sourceforge.net \
--cc=fubar@us.ibm.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).