From: "David S. Miller" <davem@davemloft.net>
To: johnpol@2ka.mipt.ru
Cc: netdev@vger.kernel.org, caitlinb@broadcom.com, kelly@au1.ibm.com,
rusty@rustcorp.com.au
Subject: Re: Initial benchmarks of some VJ ideas [mmap memcpy vs copy_to_user].
Date: Thu, 11 May 2006 11:54:09 -0700 (PDT) [thread overview]
Message-ID: <20060511.115409.89709859.davem@davemloft.net> (raw)
In-Reply-To: <20060511161815.GA623@2ka.mipt.ru>
From: Evgeniy Polyakov <johnpol@2ka.mipt.ru>
Date: Thu, 11 May 2006 20:18:15 +0400
> Here is profile result:
> 1463625 78.0003 poll_idle
> 19171 1.0217 _spin_lock_irqsave
> 15887 0.8467 _read_lock
> 14712 0.7840 kfree
> 13370 0.7125 ip_frag_queue
> 11896 0.6340 delay_pmtmr
> 11811 0.6294 _spin_lock
> 11723 0.6247 csum_partial
> 11399 0.6075 ip_frag_destroy
> 11063 0.5896 serial_in
> 10533 0.5613 skb_release_data
> 10524 0.5609 ip_route_input
> 10319 0.5499 __alloc_skb
Too bad spinlocks are not inlined any longer, this makes oprofile
output so much less useful.
Also, since you test UDP with >MTU sized sends, you add fragmentation
into the mix, yet another variable that you won't see with TCP :-)
BTW you make another massively critical error in your analysis of TCP
profiles.
You mention that "tcp_v4_rcv()" shows up in your profiles and not
__inet_lookup(). This __inet_lookup() is inlined, and thus it's cost
shows up as "tcp_v4_rcv()". I find such oversight amazing for someone
as careful about details as you are :-)
I would suggest to look at instruction level profile hits, it makes
such mistakes in analysis almost impossible :-)
next prev parent reply other threads:[~2006-05-11 18:54 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-05-08 12:24 Initial benchmarks of some VJ ideas [mmap memcpy vs copy_to_user] Evgeniy Polyakov
2006-05-08 19:51 ` Evgeniy Polyakov
2006-05-08 20:15 ` David S. Miller
2006-05-10 19:58 ` David S. Miller
2006-05-11 6:40 ` Evgeniy Polyakov
2006-05-11 7:07 ` David S. Miller
2006-05-11 8:30 ` Evgeniy Polyakov
2006-05-11 16:18 ` Evgeniy Polyakov
2006-05-11 18:54 ` David S. Miller [this message]
2006-05-11 19:30 ` Rick Jones
2006-05-12 7:54 ` Evgeniy Polyakov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060511.115409.89709859.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=caitlinb@broadcom.com \
--cc=johnpol@2ka.mipt.ru \
--cc=kelly@au1.ibm.com \
--cc=netdev@vger.kernel.org \
--cc=rusty@rustcorp.com.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).