From: Jiri Benc <jbenc@suse.cz>
To: "John W. Linville" <linville@tuxdriver.com>
Cc: Ivo van Doorn <ivdoorn@gmail.com>, NetDev <netdev@vger.kernel.org>
Subject: [PATCH] rt2x00: fix oops in config_interface
Date: Thu, 11 May 2006 17:06:42 +0200 [thread overview]
Message-ID: <20060511170642.3d03f46d@griffin.suse.cz> (raw)
BSSID passed to config_interface callback is NULL in modes other than STA or
IBSS.
Signed-off-by: Jiri Benc <jbenc@suse.cz>
---
drivers/net/wireless/d80211/rt2x00/rt2400pci.c | 3 ++-
drivers/net/wireless/d80211/rt2x00/rt2500pci.c | 3 ++-
drivers/net/wireless/d80211/rt2x00/rt2500usb.c | 3 ++-
drivers/net/wireless/d80211/rt2x00/rt61pci.c | 3 ++-
drivers/net/wireless/d80211/rt2x00/rt73usb.c | 3 ++-
5 files changed, 10 insertions(+), 5 deletions(-)
--- dscape.orig/drivers/net/wireless/d80211/rt2x00/rt2400pci.c
+++ dscape/drivers/net/wireless/d80211/rt2x00/rt2400pci.c
@@ -1848,7 +1848,8 @@ rt2400pci_config_interface(struct net_de
if (rt2x00pci->type == IEEE80211_IF_TYPE_MNTR)
return 0;
- rt2400pci_config_bssid(rt2x00pci, conf->bssid);
+ if (conf->bssid)
+ rt2400pci_config_bssid(rt2x00pci, conf->bssid);
return 0;
}
--- dscape.orig/drivers/net/wireless/d80211/rt2x00/rt2500pci.c
+++ dscape/drivers/net/wireless/d80211/rt2x00/rt2500pci.c
@@ -1971,7 +1971,8 @@ rt2500pci_config_interface(struct net_de
if (conf->type == IEEE80211_IF_TYPE_MNTR)
return 0;
- rt2500pci_config_bssid(rt2x00pci, conf->bssid);
+ if (conf->bssid)
+ rt2500pci_config_bssid(rt2x00pci, conf->bssid);
return 0;
}
--- dscape.orig/drivers/net/wireless/d80211/rt2x00/rt2500usb.c
+++ dscape/drivers/net/wireless/d80211/rt2x00/rt2500usb.c
@@ -1636,7 +1636,8 @@ rt2500usb_config_interface(struct net_de
if (conf->type == IEEE80211_IF_TYPE_MNTR)
return 0;
- rt2500usb_config_bssid(rt2x00usb, conf->bssid);
+ if (conf->bssid)
+ rt2500usb_config_bssid(rt2x00usb, conf->bssid);
return 0;
}
--- dscape.orig/drivers/net/wireless/d80211/rt2x00/rt61pci.c
+++ dscape/drivers/net/wireless/d80211/rt2x00/rt61pci.c
@@ -2434,7 +2434,8 @@ rt61pci_config_interface(struct net_devi
if (conf->type == IEEE80211_IF_TYPE_MNTR)
return 0;
- rt61pci_config_bssid(rt2x00pci, conf->bssid);
+ if (conf->bssid)
+ rt61pci_config_bssid(rt2x00pci, conf->bssid);
return 0;
}
--- dscape.orig/drivers/net/wireless/d80211/rt2x00/rt73usb.c
+++ dscape/drivers/net/wireless/d80211/rt2x00/rt73usb.c
@@ -1935,7 +1935,8 @@ rt73usb_config_interface(struct net_devi
if (conf->type == IEEE80211_IF_TYPE_MNTR)
return 0;
- rt73usb_config_bssid(rt2x00usb, conf->bssid);
+ if (conf->bssid)
+ rt73usb_config_bssid(rt2x00usb, conf->bssid);
return 0;
}
--
Jiri Benc
SUSE Labs
reply other threads:[~2006-05-11 15:06 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060511170642.3d03f46d@griffin.suse.cz \
--to=jbenc@suse.cz \
--cc=ivdoorn@gmail.com \
--cc=linville@tuxdriver.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox