netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Stephen Hemminger <shemminger@osdl.org>
To: Lennert Buytenhek <buytenh@wantstofly.org>
Cc: jgarzik@pobox.com, netdev@vger.kernel.org
Subject: Re: ixp2000: handle enp2611s with two gigabit ports
Date: Mon, 15 May 2006 12:26:13 -0700	[thread overview]
Message-ID: <20060515122613.6f10eb3e@localhost.localdomain> (raw)
In-Reply-To: <20060426222411.GA9882@xi.wantstofly.org>

On Thu, 27 Apr 2006 00:24:11 +0200
Lennert Buytenhek <buytenh@wantstofly.org> wrote:

> The ixp2000 driver for the enp2611 was developed on a board with
> three gigabit ports, but some enp2611 models only have two ports
> (and only one onboard PM3386.)  The current driver assumes there
> are always three ports and so it doesn't work on the two-port
> version of the board at all.
> 
> This patch adds a bit of logic to the enp2611 driver to limit the
> number of ports to 2 if the second PM3386 isn't detected.
> 
> Signed-off-by: Lennert Buytenhek <buytenh@wantstofly.org>

This patch got mangled, that is probably why jeff didn't apply it before
he left. I had to fix it manually.

patching file drivers/net/ixp2000/enp2611.c
patch: **** malformed patch at line 106:
module_init(enp2611_init_module);

In this part...

@@ -236,8 +240,10 @@
 	del_timer_sync(&link_check_timer);
 
 	ixpdev_deinit();
-	for (i = 0; i < 3; i++)
-		free_netdev(nds[i]);
+	for (i = 0; i < 3; i++) {
+		if (nds[i] != NULL)
			free_netdev(nds[i]);
+	}
 }
 
 module_init(enp2611_init_module);

      reply	other threads:[~2006-05-15 19:27 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-04-26 22:24 ixp2000: handle enp2611s with two gigabit ports Lennert Buytenhek
2006-05-15 19:26 ` Stephen Hemminger [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20060515122613.6f10eb3e@localhost.localdomain \
    --to=shemminger@osdl.org \
    --cc=buytenh@wantstofly.org \
    --cc=jgarzik@pobox.com \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).