From: "David S. Miller" <davem@davemloft.net>
To: johnpol@2ka.mipt.ru
Cc: netdev@vger.kernel.org
Subject: Re: [1/1] connector: export cn_already_initialized.
Date: Tue, 16 May 2006 16:14:06 -0700 (PDT) [thread overview]
Message-ID: <20060516.161406.23276754.davem@davemloft.net> (raw)
In-Reply-To: <20060506084045.GA16558@2ka.mipt.ru>
From: Evgeniy Polyakov <johnpol@2ka.mipt.ru>
Date: Sat, 6 May 2006 12:40:45 +0400
> Some external patches, which can be built both as static build and as
> module just check that value, and thus will fail with unresolved symbol
> when cn and module are built as modules.
>
> The right set of operations should be following:
> If external module is loaded and cn is not loaded or compiled into the
> kernel, insmod will just fail with unresolved symbol (cn_add_callback and others),
> if cn is already loaded or was built into the tree, then it has been
> initialized already and there is no need to check that value, external
> module should be just loaded.
>
> I think the right solution is to call external init functions after cn
> init function, but it's ordering is not always known.
In-kernel build of connector subsystem can be handled by
making cn_init a "subsystem_init()", it will then be setup
before any possible static or modular reference as long as
those modules use module_init().
For modular case of connector, dependency of module on connector
module should handle all ordering issues, making any ordering
issue take care of itself.
next prev parent reply other threads:[~2006-05-16 23:14 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-05-04 12:24 [1/1] connector: export cn_already_initialized Evgeniy Polyakov
2006-05-06 0:16 ` David S. Miller
2006-05-06 8:40 ` Evgeniy Polyakov
2006-05-16 23:14 ` David S. Miller [this message]
2006-05-24 8:38 ` Evgeniy Polyakov
2006-06-19 5:30 ` Evgeniy Polyakov
2006-06-20 6:43 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060516.161406.23276754.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=johnpol@2ka.mipt.ru \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).