From: Adrian Bunk <bunk@stusta.de>
To: Andreas Mohr <andi@rhlx01.fht-esslingen.de>
Cc: Andrew Morton <akpm@osdl.org>,
Ananda Raju <ananda.raju@neterion.com>,
jgarzik@pobox.com, linux-kernel@vger.kernel.org,
netdev@vger.kernel.org
Subject: Re: [-mm patch] drivers/net/s2io.c: make bus_speed[] static
Date: Tue, 16 May 2006 18:42:10 +0200 [thread overview]
Message-ID: <20060516164210.GI5677@stusta.de> (raw)
In-Reply-To: <20060516153611.GA13270@rhlx01.fht-esslingen.de>
On Tue, May 16, 2006 at 05:36:11PM +0200, Andreas Mohr wrote:
> Hi,
>
> On Tue, May 16, 2006 at 05:30:50PM +0200, Adrian Bunk wrote:
> > This patch makes the needlessly global bus_speed[] static.
>
> Is there a reason why you don't also constify it while you are at it?
> Or is it because you want to do a series of static-only patches for now?
The latter.
Feel free to send a patch that also makes it const.
> Andreas Mohr
cu
Adrian
--
"Is there not promise of rain?" Ling Tan asked suddenly out
of the darkness. There had been need of rain for many days.
"Only a promise," Lao Er said.
Pearl S. Buck - Dragon Seed
next prev parent reply other threads:[~2006-05-16 16:42 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20060515005637.00b54560.akpm@osdl.org>
2006-05-16 15:30 ` [-mm patch] drivers/net/s2io.c: make bus_speed[] static Adrian Bunk
2006-05-16 15:36 ` Andreas Mohr
2006-05-16 16:42 ` Adrian Bunk [this message]
2006-05-24 5:28 ` Jeff Garzik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060516164210.GI5677@stusta.de \
--to=bunk@stusta.de \
--cc=akpm@osdl.org \
--cc=ananda.raju@neterion.com \
--cc=andi@rhlx01.fht-esslingen.de \
--cc=jgarzik@pobox.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).