From: "John W. Linville" <linville@tuxdriver.com>
To: Michael Wu <flamingice@sourmilk.net>
Cc: Jiri Benc <jbenc@suse.cz>, Jouni Malinen <jkm@devicescape.com>,
netdev@vger.kernel.org, jkmaline@cc.hut.fi
Subject: Re: [PATCH wireless-dev] d80211: Don't discriminate against 802.11b drivers
Date: Fri, 19 May 2006 14:06:54 -0400 [thread overview]
Message-ID: <20060519180649.GD30177@tuxdriver.com> (raw)
In-Reply-To: <200605151319.23246.flamingice@sourmilk.net>
On Mon, May 15, 2006 at 01:19:23PM -0400, Michael Wu wrote:
> On Monday 15 May 2006 07:37, Jiri Benc wrote:
> > This issue can be easily solved by not masking hw_modes by
> > valid_hw_modes in ieee80211_ioctl_prism2_param and
> > ieee80211_precalc_modes. Just check (hw_modes & valid_hw_modes) instead
> > of hw_modes in ieee80211_sta_scan_timer.
> >
> > And yes, hw_modes is a confusing name. It should be named
> > hw_modes_mask_disabled_by_user or so. Maybe at least some better comment
> > about this in ieee80211_i.h won't be a bad idea.
> >
> Okay, how about this? Instead of adding valid_hw_modes, I added enabled_modes,
> and replaced all instances of local->hw_modes with local->enabled_modes.
> local->hw_modes now really means what modes are supported by the hardware.
Are we satisfied w/ this patch? If so, please repost the patch after
cleaning-up the changelog according to the rules here:
http://linux.yyz.us/patch-format.html
Thanks,
John
--
John W. Linville
linville@tuxdriver.com
next prev parent reply other threads:[~2006-05-19 18:07 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-05-05 2:32 [PATCH wireless-dev] d80211: Don't discriminate against 802.11b drivers Michael Wu
2006-05-11 15:54 ` Jiri Benc
2006-05-10 17:31 ` Michael Wu
2006-05-12 10:47 ` Jiri Benc
2006-05-12 20:35 ` Michael Wu
2006-05-15 11:37 ` Jiri Benc
2006-05-15 12:04 ` Johannes Berg
2006-05-15 13:35 ` Jiri Benc
2006-05-15 14:01 ` Michael Buesch
2006-05-15 14:12 ` Jiri Benc
2006-05-15 17:19 ` Michael Wu
2006-05-19 18:06 ` John W. Linville [this message]
2006-05-19 19:03 ` Michael Wu
2006-05-19 19:22 ` John W. Linville
2006-05-11 20:41 ` Michael Buesch
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060519180649.GD30177@tuxdriver.com \
--to=linville@tuxdriver.com \
--cc=flamingice@sourmilk.net \
--cc=jbenc@suse.cz \
--cc=jkm@devicescape.com \
--cc=jkmaline@cc.hut.fi \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).