netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Chris Wedgwood <cw@f00f.org>
To: netdev <netdev@vger.kernel.org>
Cc: "David S. Miller" <davem@davemloft.net>
Subject: [PATCH] Disable multipath cache routing
Date: Fri, 19 May 2006 19:52:43 -0700	[thread overview]
Message-ID: <20060520025243.GA9486@taniwha.stupidest.org> (raw)

Apparently IP_ROUTE_MULTIPATH_CACHED isn't entirely safe to use and
will oops the kernel "sooner or later".  The Kconfig comment says
EXPERIMENTAL but it's not.

Let's go further and mark it BROKEN for now (leaving the comment as-is
though).  If nobody steps up to resurrect this code we can discuss
removing it entirely.


Signed-off-by: Chris Wedgwood <cw@f00f.org>

diff --git a/net/ipv4/Kconfig b/net/ipv4/Kconfig
index 011cca7..3a08b9e 100644
--- a/net/ipv4/Kconfig
+++ b/net/ipv4/Kconfig
@@ -124,7 +124,7 @@ config IP_ROUTE_MULTIPATH
 
 config IP_ROUTE_MULTIPATH_CACHED
 	bool "IP: equal cost multipath with caching support (EXPERIMENTAL)"
-	depends on IP_ROUTE_MULTIPATH
+	depends on IP_ROUTE_MULTIPATH && BROKEN
 	help
 	  Normally, equal cost multipath routing is not supported by the
 	  routing cache. If you say Y here, alternative routes are cached

             reply	other threads:[~2006-05-20  2:52 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-05-20  2:52 Chris Wedgwood [this message]
     [not found] <446ED597.20300@calsoftinc.com>
2006-05-20  9:41 ` [PATCH] Disable multipath cache routing pravin b shelar
2006-05-20 20:51   ` Chris Wedgwood

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20060520025243.GA9486@taniwha.stupidest.org \
    --to=cw@f00f.org \
    --cc=davem@davemloft.net \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).