From mboxrd@z Thu Jan 1 00:00:00 1970 From: Nathan Lynch Subject: Re: [PATCH 1/9] [I/OAT] DMA memcpy subsystem Date: Wed, 24 May 2006 01:31:49 -0500 Message-ID: <20060524063149.GE11414@localdomain> References: <20060524001653.19403.31396.stgit@gitlost.site> <20060524002012.19403.50151.stgit@gitlost.site> <20060523174827.0ce1943b.akpm@osdl.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Chris Leech , linux-kernel@vger.kernel.org, netdev@vger.kernel.org Return-path: Received: from rune.pobox.com ([208.210.124.79]:18079 "EHLO rune.pobox.com") by vger.kernel.org with ESMTP id S932616AbWEXGb4 (ORCPT ); Wed, 24 May 2006 02:31:56 -0400 To: Andrew Morton Content-Disposition: inline In-Reply-To: <20060523174827.0ce1943b.akpm@osdl.org> Sender: netdev-owner@vger.kernel.org List-Id: netdev.vger.kernel.org Andrew Morton wrote: > Chris Leech wrote: > > > > + for_each_cpu(i) > > That's about to be deleted. Please use for_each_possible_cpu(). > > That's if for_each_possible_cpu() is appropriate. It is -- those loops traverse chan->local, which is alloc_percpu'd, which allocates for all possible cpus.