From: Francois Romieu <romieu@fr.zoreil.com>
To: Gary Zambrano <zambrano@broadcom.com>
Cc: Jeff Garzik <jeff@garzik.org>, netdev@vger.kernel.org
Subject: Re: [PATCH 1/4] b44: add wol and setup for later 4401
Date: Thu, 25 May 2006 00:06:58 +0200 [thread overview]
Message-ID: <20060524220658.GA2863@electric-eye.fr.zoreil.com> (raw)
In-Reply-To: <1148481644.2976.51.camel@dhcp-10-7-81-7.broadcom.com>
Gary Zambrano <zambrano@broadcom.com> :
>
> This patch adds set and get functions and support for the later 4401 revs.
>
> Signed-off-by: Gary Zambrano <zambrano@broadcom.com>
>
> diff --git a/drivers/net/b44.c b/drivers/net/b44.c
> index 7b3dfc4..e42e0aa 100644
> --- a/drivers/net/b44.c
> +++ b/drivers/net/b44.c
[...]
> @@ -1467,6 +1510,11 @@ static int b44_close(struct net_device *
>
> netif_poll_enable(dev);
>
> + if (bp->flags & B44_FLAG_WOL_ENABLE){
> + b44_init_hw(bp);
> + b44_setup_wol(bp);
> + }
> +
> b44_free_consistent(bp);
>
> return 0;
Should b44_setup_wol() not be used in b44_suspend() as well ?
(nit: s/){/) {/)
--
Ueimor
next prev parent reply other threads:[~2006-05-24 22:08 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-05-24 14:40 [PATCH 1/4] b44: add wol and setup for later 4401 Gary Zambrano
2006-05-24 22:06 ` Francois Romieu [this message]
2006-05-24 15:27 ` Gary Zambrano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060524220658.GA2863@electric-eye.fr.zoreil.com \
--to=romieu@fr.zoreil.com \
--cc=jeff@garzik.org \
--cc=netdev@vger.kernel.org \
--cc=zambrano@broadcom.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox