From: Olof Johansson <olof@lixom.net>
To: Chris Leech <christopher.leech@intel.com>
Cc: linux-kernel@vger.kernel.org, netdev@vger.kernel.org
Subject: Re: [PATCH 2/9] [I/OAT] Driver for the Intel(R) I/OAT DMA engine
Date: Thu, 25 May 2006 11:00:57 -0700 [thread overview]
Message-ID: <20060525180057.GC9867@pb15.lixom.net> (raw)
In-Reply-To: <20060524002013.19403.57410.stgit@gitlost.site>
Hi,
Minor nitpick below:
On Tue, May 23, 2006 at 05:20:13PM -0700, Chris Leech wrote:
> +static int enumerate_dma_channels(struct ioat_device *device)
[...]
> + enumerate_dma_channels(device);
Return value is never used, might as well change the function
declaration to void.
-Olof
next prev parent reply other threads:[~2006-05-25 18:01 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-05-24 0:16 [PATCH 0/9] I/OAT repost Chris Leech
2006-05-24 0:20 ` [PATCH 1/9] [I/OAT] DMA memcpy subsystem Chris Leech
2006-05-24 0:48 ` Andrew Morton
2006-05-24 6:31 ` Nathan Lynch
2006-05-24 0:51 ` Andrew Morton
2006-05-25 17:59 ` Olof Johansson
2006-05-25 18:09 ` Olof Johansson
2006-05-24 0:20 ` [PATCH 2/9] [I/OAT] Driver for the Intel(R) I/OAT DMA engine Chris Leech
2006-05-24 0:56 ` Andrew Morton
2006-05-25 18:00 ` Olof Johansson [this message]
2006-05-30 23:27 ` Adrian Bunk
2006-05-24 0:20 ` [PATCH 3/9] [I/OAT] Setup the networking subsystem as a DMA client Chris Leech
2006-05-24 1:13 ` David Miller
2006-05-24 0:20 ` [PATCH 4/9] [I/OAT] Utility functions for offloading sk_buff to iovec copies Chris Leech
2006-05-24 0:20 ` [PATCH 5/9] [I/OAT] Structure changes for TCP recv offload to I/OAT Chris Leech
2006-05-24 0:20 ` [PATCH 6/9] [I/OAT] Rename cleanup_rbuf to tcp_cleanup_rbuf and make non-static Chris Leech
2006-05-24 0:20 ` [PATCH 7/9] [I/OAT] make sk_eat_skb I/OAT aware Chris Leech
2006-05-24 0:20 ` [PATCH 8/9] [I/OAT] Add a sysctl for tuning the I/OAT offloaded I/O threshold Chris Leech
2006-05-24 1:02 ` Andrew Morton
2006-05-24 0:20 ` [PATCH 9/9] [I/OAT] TCP recv offload to I/OAT Chris Leech
2006-05-24 0:22 ` [PATCH 0/9] I/OAT repost David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060525180057.GC9867@pb15.lixom.net \
--to=olof@lixom.net \
--cc=christopher.leech@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).