From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stephen Hemminger Subject: Re: [PATCH] eth1394: endian fixes Date: Sat, 27 May 2006 09:40:19 -0700 Message-ID: <20060527094019.4d451093@localhost.localdomain> References: <20060519132539.GC17751@mipter.zuzino.mipt.ru> <44782474.9050304@s5r6.in-berlin.de> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Cc: Alexey Dobriyan , netdev@vger.kernel.org, linux1394-devel@lists.sourceforge.net Return-path: Received: from smtp.osdl.org ([65.172.181.4]:56519 "EHLO smtp.osdl.org") by vger.kernel.org with ESMTP id S964873AbWE0Qki (ORCPT ); Sat, 27 May 2006 12:40:38 -0400 To: Stefan Richter In-Reply-To: <44782474.9050304@s5r6.in-berlin.de> Sender: netdev-owner@vger.kernel.org List-Id: netdev.vger.kernel.org On Sat, 27 May 2006 12:05:40 +0200 Stefan Richter wrote: > Alexey Dobriyan wrote on 2006-05-16: > > Signed-off-by: Alexey Dobriyan > ... > > @@ -935,7 +935,7 @@ static inline u16 ether1394_parse_encap( > > *(u32*)arp_ptr = arp1394->sip; /* move sender IP addr */ > > arp_ptr += arp->ar_pln; /* skip over sender IP addr */ > > > > - if (arp->ar_op == 1) > > + if (arp->ar_op == htons(1)) > > /* just set ARP req target unique ID to 0 */ > > *((u64*)arp_ptr) = 0; > > else > > I suggest __constant_htons(ARPOP_REQUEST). No. That is only for initializers and switch cases. Otherwise, it adds unnecessary verbosity. The htons() does the right thing automatically. > > > @@ -1395,7 +1395,7 @@ static inline void ether1394_arp_to_1394 > > /* We need to encapsulate the standard header with our own. We use the > > * ethernet header's proto for our own. */ > > static inline unsigned int ether1394_encapsulate_prep(unsigned int max_payload, > > - int proto, > > + __be16 proto, > > union eth1394_hdr *hdr, > > u16 dg_size, u16 dgl) > > { > > @@ -1626,7 +1626,7 @@ static int ether1394_tx (struct sk_buff > > gfp_t kmflags = in_interrupt() ? GFP_ATOMIC : GFP_KERNEL; > > struct eth1394hdr *eth; > > struct eth1394_priv *priv = netdev_priv(dev); > > - int proto; > > + __be16 proto; > > unsigned long flags; > > nodeid_t dest_node; > > eth1394_tx_type tx_type; > > Alexey, I am afraid none of the current 1394 developers is actively > using eth1394. Did you have the chance to test your patch on different > platforms and with different peer OSs/platforms? > > Also, did someone of the netdev guys already forward the patch (since we > 1394 people are slow and eth1394 is marked unmaintained)? If not, I > could send it along with a few other 1394 patches to akpm soon. > -- > Stefan Richter > -=====-=-==- -=-= ==-== > http://arcgraph.de/sr/ > - > To unsubscribe from this list: send the line "unsubscribe netdev" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html